Page MenuHomePhabricator
Create Task
Maniphest T252253

Inject services to SpecialBlock rather than summon them through MediaWikiServices class
Closed, ResolvedPublic
Actions

Description

Preferred solution of using services is to inject them.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
SpecialBlock: Inject PermissionManager rather than creating it through MediaWikiServicesmediawiki/coremaster+23 -12
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm created this task.May 8 2020, 10:23 PM
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptMay 8 2020, 10:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm triaged this task as Low priority.May 8 2020, 10:32 PM
Urbanecm added a project: Platform Team Workboards (External Code Reviews).
gerritbot added a comment.May 8 2020, 10:32 PM

Change 595242 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] SpecialBlock: Inject PermissionManager rather than creating it through MediaWikiServices

https://gerrit.wikimedia.org/r/595242

gerritbot added a project: Patch-For-Review.May 8 2020, 10:32 PM
dbarratt merged a task: T221383: SpecialBlock should not be aware of the container.May 11 2020, 3:58 PM
dbarratt added a project: Anti-Harassment-Team.
dbarratt added subscribers: dbarratt, daniel, MGChecker.
gerritbot added a comment.May 12 2020, 7:35 AM

Change 595242 merged by jenkins-bot:
[mediawiki/core@master] SpecialBlock: Inject PermissionManager rather than creating it through MediaWikiServices

https://gerrit.wikimedia.org/r/595242

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 12 2020, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 12 2020, 8:10 AM
• Pchelolo moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (External Code Reviews) board.May 12 2020, 2:14 PM
Urbanecm closed this task as Resolved.May 12 2020, 6:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits