Add tests for JS code
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	May 8 2020, 11:36 PM

Description

Jest is currently being recommended for Vue.js code, but Nearby has non-Vue code too. It's unclear what's going to be better here. Ideally I don't want to write both QUnit and Jest - that seems counterintutive to me.

Writing code in Jest will likely require stubbing mediawiki in some way and possibly require sinon.

todo

Work out what the recommendations are around Jest and QUnit. Should I just write in Jest?
Get 75%+ test coverage for the small amount of code in the repo

Details

Subject	Repo	Branch	Lines +/-
Add test coverage for App.vue	mediawiki/extensions/NearbyPages	master	+215 -2
Add coverage dir to .gitignore	mediawiki/extensions/NearbyPages	master	+1 -0
Add Jest unit testing	mediawiki/extensions/NearbyPages	master	+2 K -39

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T246493 [EPIC] Deploy NearbyPages everywhere
Resolved	Jdlrobson	T246495 [EPIC] Build a new version of Special:Nearby using Vue framework
Resolved	None	T252263 Add tests for JS code

Event Timeline

Jdlrobson created this task.May 8 2020, 11:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 8 2020, 11:36 PM

Jdlrobson moved this task from Backlog to Todo on the NearbyPages board.May 8 2020, 11:36 PM

Jdlrobson added a parent task: T246495: [EPIC] Build a new version of Special:Nearby using Vue framework.

Jdlrobson mentioned this in T246503: Build the Card and PageList component in Vue.

Change 597870 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/NearbyPages@master] Add Jest unit testing

https://gerrit.wikimedia.org/r/597870

gerritbot added a project: Patch-For-Review.May 21 2020, 9:43 PM

Change 597870 merged by jenkins-bot:
[mediawiki/extensions/NearbyPages@master] Add Jest unit testing

https://gerrit.wikimedia.org/r/597870

Maintenance_bot removed a project: Patch-For-Review.May 28 2020, 5:11 PM

Jdlrobson updated the task description. (Show Details)May 28 2020, 5:27 PM

Reedy mentioned this in T254062: library upgrader added coverage files to NearbyPages.May 30 2020, 7:47 PM

Change 600405 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/NearbyPages@master] Add coverage dir to .gitignore

https://gerrit.wikimedia.org/r/600405

gerritbot added a project: Patch-For-Review.May 30 2020, 7:53 PM

Change 600405 merged by jenkins-bot:
[mediawiki/extensions/NearbyPages@master] Add coverage dir to .gitignore

https://gerrit.wikimedia.org/r/600405

Maintenance_bot removed a project: Patch-For-Review.May 31 2020, 4:10 PM

Change 601468 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/NearbyPages@master] WIP: Add test coverage for App.vue

https://gerrit.wikimedia.org/r/601468

gerritbot added a project: Patch-For-Review.Jun 1 2020, 11:38 PM

Change 601468 merged by jenkins-bot:
[mediawiki/extensions/NearbyPages@master] Add test coverage for App.vue

https://gerrit.wikimedia.org/r/601468

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2020, 11:10 PM

Jdlrobson closed this task as Resolved.Jun 9 2020, 11:24 PM

Jdlrobson updated the task description. (Show Details)