Page MenuHomePhabricator
Create Task
Maniphest T252264

Deploy Reply tool via query string parameter to zh.wiki
Closed, ResolvedPublic
Actions

Description

This task is about enabling people at zh.wiki to experiment with the Reply tool via a query string parameter to ensure the tool works in ways people expect it to.

Timing

Provisional timing...
Timing is TBD considering there is not deployment train this week. [1]

Blockers
This task is blocked by T252258: Determine what technical requirements must be met before #DiscussionTools can be deployed to a new wiki

Done

  • The Replying tool is available for people at zh.wiki to test by appending a query string parameter to any URL where DT are already enabled (T245890#6025053)
  1. https://wikitech.wikimedia.org/wiki/Deployments#Week_of_May_18

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Install DiscussionTools on all wikis (attempt 2)operations/mediawiki-configmaster+5 -7
Use $wgLocaltimezone global instead of request contextmediawiki/extensions/DiscussionToolswmf/1.35.0-wmf.37+3 -2
Revert "Install DiscussionTools on all wikis"operations/mediawiki-configmaster+7 -5
Install DiscussionTools on all wikisoperations/mediawiki-configmaster+5 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

ppelberg created this task.May 8 2020, 11:42 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMay 8 2020, 11:42 PM
ppelberg removed VulpesVulpes825 as the assignee of this task.May 8 2020, 11:42 PM
ppelberg mentioned this in T251075: Enable DiscussionTools on zhwiki.
Hamishcn subscribed.May 8 2020, 11:47 PM
ppelberg updated the task description. (Show Details)May 8 2020, 11:49 PM
ppelberg edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed Editing-team.
ppelberg updated the task description. (Show Details)May 8 2020, 11:51 PM
ppelberg moved this task from Needs Discussion / Investigation to Upcoming on the Editing-team (Q3 2019-2020 Kanban Board) board.May 8 2020, 11:55 PM
Urbanecm moved this task from Backlog to Config - to process on the Wikimedia-Site-requests board.May 14 2020, 6:34 PM
SCP-2000 subscribed.May 16 2020, 6:36 AM
ppelberg updated the task description. (Show Details)May 21 2020, 1:25 AM

FYI @VulpesVulpes825, the Reply tool will not be made available at zh.wiki via a custom URL tomorrow, 21-May, as we had talked about before (T251075#6120494).

The reason: there is no deployment train this week. [1]

  1. https://wikitech.wikimedia.org/wiki/Deployments#Week_of_May_18
ppelberg added a comment.EditedMay 21 2020, 9:33 PM

We are going to revisit this task once T252255 is resolved.

Reason: we do not want to deploy the feature more widely until we, as a team, have a common understanding of the requirements that need to be met for this happens.

MarcoAurelio changed the task status from Open to Stalled.May 26 2020, 8:58 AM
MarcoAurelio moved this task from Config - to process to Blocked on development on the Wikimedia-Site-requests board.
Esanders subscribed.May 27 2020, 3:07 PM

I don't see anything in T252255 that would block this. The query string parameter deploy is intended for identifying potential issues outlined in that document.

Esanders added a comment.EditedMay 27 2020, 3:09 PM

Also given that enabling the query string on en.wiki resulted in almost no activity beyond WMF staff (https://w.wiki/Ryu) I would suggest that we should just turn on the query string feature for all wikis.

gerritbot added a comment.May 28 2020, 11:23 AM

Change 599307 had a related patch set uploaded (by Esanders; owner: Esanders):
[operations/mediawiki-config@master] Install DiscussionTools on all wikis

https://gerrit.wikimedia.org/r/599307

gerritbot added a project: Patch-For-Review.May 28 2020, 11:23 AM
ppelberg added a comment.May 29 2020, 1:06 AM
In T252264#6169342, @Esanders wrote:

...I would suggest that we should just turn on the query string feature for all wikis.

@Whatamidoing-WMF and I discussed this today and we agree about making the tool available for all Wikipedias via the query string.

Prior to this happening (T253943), we need to update the documentation. See: T253942.

gerritbot added a comment.Jun 17 2020, 6:18 PM

Change 599307 merged by jenkins-bot:
[operations/mediawiki-config@master] Install DiscussionTools on all wikis

https://gerrit.wikimedia.org/r/599307

Stashbot added a comment.Jun 17 2020, 6:24 PM

Mentioned in SAL (#wikimedia-operations) [2020-06-17T18:24:15Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: REVERT: ae76450: Install DiscussionTools on all wikis (T252264; T253943) (duration: 00m 34s)

Stashbot mentioned this in T253943: Enable DiscussionTools at all wikis via query string.Jun 17 2020, 6:24 PM
gerritbot added a comment.Jun 17 2020, 6:26 PM

Change 606235 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Revert "Install DiscussionTools on all wikis"

https://gerrit.wikimedia.org/r/606235

gerritbot added a comment.Jun 17 2020, 6:27 PM

Change 606235 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "Install DiscussionTools on all wikis"

https://gerrit.wikimedia.org/r/606235

gerritbot added a comment.Jun 17 2020, 9:58 PM

Change 606279 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[mediawiki/extensions/DiscussionTools@wmf/1.35.0-wmf.37] Use $wgLocaltimezone global instead of request context

https://gerrit.wikimedia.org/r/606279

gerritbot added a comment.Jun 17 2020, 9:58 PM

Change 606280 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[operations/mediawiki-config@master] Install DiscussionTools on all wikis (attempt 2)

https://gerrit.wikimedia.org/r/606280

gerritbot added a comment.Jun 17 2020, 11:05 PM

Change 606279 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@wmf/1.35.0-wmf.37] Use $wgLocaltimezone global instead of request context

https://gerrit.wikimedia.org/r/606279

gerritbot added a comment.Jun 17 2020, 11:16 PM

Change 606280 merged by jenkins-bot:
[operations/mediawiki-config@master] Install DiscussionTools on all wikis (attempt 2)

https://gerrit.wikimedia.org/r/606280

Stashbot added a comment.Jun 17 2020, 11:21 PM

Mentioned in SAL (#wikimedia-operations) [2020-06-17T23:21:49Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.37/extensions/DiscussionTools/includes/Hooks.php: 4551d29: Use $wgLocaltimezone global instead of request context (T252264; T253943; T255704) (duration: 00m 58s)

Stashbot mentioned this in T255704: Fatal LogicException: Role mediainfo is already defined (DiscussionTools conflicts with WikibaseMediaInfo).Jun 17 2020, 11:21 PM
Stashbot added a comment.Jun 17 2020, 11:25 PM

Mentioned in SAL (#wikimedia-operations) [2020-06-17T23:25:03Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: 0e7079d: Install DiscussionTools on all wikis (attempt 2) (T252264; T253943) (duration: 00m 56s)

matmarex removed a project: Patch-For-Review.Jun 17 2020, 11:48 PM
matmarex moved this task from Upcoming to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.
matmarex subscribed.

It's enabled now! We had to temporarily revert the deployment earlier today (see T253943), but it looks good now.

Shizhao moved this task from Backlog to Site configuration on the Chinese-Sites board.Jun 22 2020, 2:29 AM
VulpesVulpes825 closed this task as Resolved.Jun 22 2020, 4:55 AM
VulpesVulpes825 moved this task from Site configuration to Closed on the Chinese-Sites board.

Enabled via T253943.

Stang unsubscribed.Nov 14 2021, 12:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits