Page MenuHomePhabricator
Create Task
Maniphest T252273

Archive the SmoothGallery extension
Closed, ResolvedPublicRequest
Actions

Description

Reason
Per its own page, "Stopped working somewhere around 1.17."

To-do list

  • This task
    • Add maintainers of that extension as subscribers to this task (if they have no apparent Phabricator account, notify them on-wiki or via email if possible and note it here). (I added Ryan Lane, who created the extension page. The listed maintainer, Mathias Lidal, has no Phabricator account I can find, and has been globally inactive since 2015)
    • Add Phabricator project MediaWiki-extensions-SmoothGallery as a tag for this task, and remove MediaWiki-extensions-Other as appropriate.
  • On-wiki documentation
    • Archive documentation on mediawiki.org (https://www.mediawiki.org/wiki/Extension:SmoothGallery): replace page contents with {{Archived extension|3837156|reason=Hasn't worked since around 1.17. Also see {{phab|T252273}}.}} (for extensions)
    • If documentation page was translatable, remove <translate>, visit Special:PageTranslation, and click "remove from translation" (if you don't have the translation administrator right, ask a user who does).
    • Update Wikidata item (Q21678606) associated with documentation page
      • add statement Abandonware (Q281039) to instance of (P31) together with qualifier start time (P580) = the YYYY-MM-DD date that you decided to archive extension (generally per edit history)
      • add qualifier end time (P582) = the YYYY-MM-DD (same date as above) to instance of (P31) = MediaWiki extension (Q6805426)
  • Phabricator
  • Translatewiki.net/translations
  • Configuration/tests/integrations/etc.
  • Repositories

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Archive repositorymediawiki/extensions/SmoothGallerymaster+2 -5 K
Archive the SmoothGallery extensionintegration/configmaster+4 -4
Archive the SmoothGallery extensionmediawiki/extensionsmaster+0 -5
Remove the SmoothGallery extensiontranslatewikimaster+0 -4
Customize query in gerrit

Related Objects

Event Timeline

Pppery created this task.May 9 2020, 4:00 AM
Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptMay 9 2020, 4:00 AM
Pppery edited subscribers, added: RyanLane; removed: Ryan_Lane.May 9 2020, 4:01 AM
Pppery updated the task description. (Show Details)May 9 2020, 4:04 AM
Pppery edited projects, added MediaWiki-extensions-SmoothGallery; removed MediaWiki-extensions-Other, Other-skins.
Pppery updated the task description. (Show Details)
Dinoguy1000 updated the task description. (Show Details)May 9 2020, 5:57 AM
MarcoAurelio moved this task from Backlog to Cleanup / Archival on the Diffusion-Repository-Administrators board.May 9 2020, 5:46 PM
Pppery updated the task description. (Show Details)May 9 2020, 11:42 PM
MarcoAurelio moved this task from Backlog to delete on the Wikimedia-GitHub board.May 29 2020, 6:32 PM
DannyS712 moved this task from Untriaged to Archive extensions on the Projects-Cleanup board.Sep 7 2020, 11:37 PM
Nikerabbit moved this task from Backlog to Configuration changes on the translatewiki.net board.Nov 2 2020, 2:37 PM
Kizule added subscribers: ashley, Kizule.EditedFeb 4 2021, 3:43 PM

Should this be done, as there are some commits by @ashley which are merged?

And one https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SmoothGallery/+/559050 is still "open".

Pppery added a comment.Feb 4 2021, 5:08 PM

Those look to me like pure formatting changes that couldn't possibly influence whether the code still works. Regardless, the current situation is undesirable. Either the code in fact works on newer versions, and the extension page should be updated to say that and this task declined, or the code in fact does not work on versions newer than 1.17, in which case the extension should be archived. I haven't tested it myself.

ashley added a comment.Apr 5 2021, 8:26 AM

The SmoothGallery extension looked horribly broken the last time I checked. I was waiting for those patches of mine to get merged before digging deep into it but based on the available evidence it doesn't seem like a popular extension nor is it maintained and fixing it up would likely take more than just a couple minutes or so, thus archiving it seems reasonable.

Kizule claimed this task.Apr 5 2021, 5:32 PM

Okay, let's work on archiving then.

Restricted Application added a project: User-Kizule. · View Herald TranscriptApr 5 2021, 5:32 PM
ashley mentioned this in T279372: Replace usages of Linker::link() and Linker::linkKnown() in extension SmoothGallery.Apr 6 2021, 6:11 AM
Aklapper mentioned this in T204330: Convert SmoothGallery to use extension registration.Apr 6 2021, 7:55 AM
Kizule mentioned this in MediaWiki-extensions-SmoothGallery.Apr 14 2021, 2:56 AM
Kizule updated the task description. (Show Details)
Kizule updated the task description. (Show Details)
gerritbot added a comment.Apr 14 2021, 2:59 AM

Change 679089 had a related patch set uploaded (by Zoranzoki21; author: Zoranzoki21):

[translatewiki@master] Remove the SmoothGallery extension

https://gerrit.wikimedia.org/r/679089

gerritbot added a project: Patch-For-Review.Apr 14 2021, 2:59 AM

Change 679090 had a related patch set uploaded (by Zoranzoki21; author: Zoranzoki21):

[integration/config@master] Archive the SmoothGallery extension

https://gerrit.wikimedia.org/r/679090

Kizule updated the task description. (Show Details)Apr 14 2021, 3:01 AM
gerritbot added a comment.Apr 14 2021, 3:04 AM

Change 679093 had a related patch set uploaded (by Zoranzoki21; author: Zoranzoki21):

[mediawiki/extensions/SmoothGallery@master] Archive repository

https://gerrit.wikimedia.org/r/679093

gerritbot added a comment.Apr 14 2021, 3:06 AM

Change 679094 had a related patch set uploaded (by Zoranzoki21; author: Zoranzoki21):

[mediawiki/extensions@master] Archive the SmoothGallery extension

https://gerrit.wikimedia.org/r/679094

Kizule moved this task from Inbox to To deploy on the User-Kizule board.Apr 14 2021, 3:08 AM
gerritbot added a comment.Apr 14 2021, 5:20 AM

Change 679089 merged by jenkins-bot:

[translatewiki@master] Remove the SmoothGallery extension

https://gerrit.wikimedia.org/r/679089

Kizule mentioned this in rGTWN45230b363d35: Remove the SmoothGallery extension.Apr 14 2021, 5:23 AM
Kizule added a comment.Apr 16 2021, 1:01 AM

Patches are ready for merging.

gerritbot added a comment.Apr 26 2021, 7:27 AM

Change 679094 merged by Hashar:

[mediawiki/extensions@master] Archive the SmoothGallery extension

https://gerrit.wikimedia.org/r/679094

gerritbot added a comment.Apr 26 2021, 7:32 AM

Change 679090 merged by jenkins-bot:

[integration/config@master] Archive the SmoothGallery extension

https://gerrit.wikimedia.org/r/679090

gerritbot added a comment.Apr 26 2021, 7:35 AM

Change 679093 merged by Hashar:

[mediawiki/extensions/SmoothGallery@master] Archive repository

https://gerrit.wikimedia.org/r/679093

hashar updated the task description. (Show Details)Apr 26 2021, 7:38 AM
hashar updated the task description. (Show Details)
hashar subscribed.Apr 26 2021, 7:40 AM

SoothGallery no more shows up at https://gerrit.wikimedia.org/r/plugins/gitiles/translatewiki/+/refs/heads/master/groups/MediaWiki/mediawiki-extensions.txt , maybe that is the only thing that needs to be done to remove it from Translatewiki?

Rest of the steps have been completed.

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2021, 8:10 AM
Kizule added a comment.Apr 26 2021, 10:35 AM
In T252273#7032650, @hashar wrote:

SoothGallery no more shows up at https://gerrit.wikimedia.org/r/plugins/gitiles/translatewiki/+/refs/heads/master/groups/MediaWiki/mediawiki-extensions.txt , maybe that is the only thing that needs to be done to remove it from Translatewiki?

Rest of the steps have been completed.

TWN is done, I forgot to mark it as completed. Thank you!

Kizule closed this task as Resolved.Apr 26 2021, 10:35 AM
Kizule updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits