Page MenuHomePhabricator
Create Task
Maniphest T252346

AdvancedSearch namespace pillbox label is misaligned
Closed, ResolvedPublic
Actions

Description

Text is not centered vertically:

advsearch pillbox error.png (33×85 px, 4 KB)

(screenshot is from enwiki)

This is not how the OOUI widget is meant to look like, see https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop#MenuTagMultiselectWidget-initially-selected-preset-options.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Revert "Revert "Workaround to center search terms label""mediawiki/extensions/AdvancedSearchwmf/1.42.0-wmf.1+11 -6
Fix misaligned namespace pillbox is AdvancedSearchmediawiki/extensions/AdvancedSearchmaster+4 -0
Workaround to center search terms labelmediawiki/extensions/AdvancedSearchwmf/1.42.0-wmf.1+11 -6
Workaround to center search terms labelmediawiki/extensions/AdvancedSearchmaster+11 -6
Vertically align the search labels and preview pillsmediawiki/extensions/AdvancedSearchmaster+18 -3
Customize query in gerrit

Event Timeline

Tgr created this task.May 10 2020, 4:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 10 2020, 4:12 PM
thiemowmde added a project: WMDE-TechWish-Maintenance.Jan 18 2022, 2:03 PM
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from Incoming to Backlog on the WMDE-TechWish-Maintenance board.Jan 18 2022, 2:15 PM
thiemowmde added a project: WMDE-Design.Jun 14 2023, 8:32 AM
thiemowmde updated the task description. (Show Details)
Maintenance_bot added a project: Design.Jun 14 2023, 8:45 AM
MareikeHeuerWMDE claimed this task.Sep 26 2023, 8:23 AM
MareikeHeuerWMDE added a project: WMDE-TechWish-Maintenance-2023.
MareikeHeuerWMDE moved this task from Backlog to Doing on the WMDE-TechWish-Maintenance-2023 board.
gerritbot added a comment.Sep 28 2023, 11:49 AM

Change 961776 had a related patch set uploaded (by Mareike Heuer; author: Mareike Heuer):

[mediawiki/extensions/AdvancedSearch@master] Fix misaligned namespace pillbox is AdvancedSearch

https://gerrit.wikimedia.org/r/961776

gerritbot added a project: Patch-For-Review.Sep 28 2023, 11:49 AM
lilients_WMDE moved this task from Doing to Review on the WMDE-TechWish-Maintenance-2023 board.Sep 28 2023, 12:50 PM
awight subscribed.Oct 9 2023, 12:49 PM

There are misalignments between many visual elements, all of which I would expect to be centered between their top and bottom margins:

  • Label text in one-line header
  • Pill in one-line header
  • Label in pill
  • Close box in pill
gerritbot added a comment.Oct 9 2023, 1:41 PM

Change 964538 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/AdvancedSearch@master] Vertically align the search labels and preview pills

https://gerrit.wikimedia.org/r/964538

gerritbot added a comment.Oct 10 2023, 5:52 PM

Change 964538 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Vertically align the search labels and preview pills

https://gerrit.wikimedia.org/r/964538

awight added a comment.Oct 12 2023, 11:58 AM

Keywords look pretty bad at this point:

image.png (65×278 px, 5 KB)

gerritbot added a comment.Oct 12 2023, 3:43 PM

Change 965534 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/AdvancedSearch@master] Workaround to center search terms label

https://gerrit.wikimedia.org/r/965534

awight removed MareikeHeuerWMDE as the assignee of this task.Oct 12 2023, 3:46 PM
awight added a subscriber: MareikeHeuerWMDE.

I've added another workaround and will drop the bone now. The remaining problems seem to be caused by the close box, which is impractical to adjust without getting deep into oo.ui itself. Probably these elements would be much easier to lay out with newer CSS features such as flex.

gerritbot added a comment.Oct 17 2023, 12:17 PM

Change 965534 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Workaround to center search terms label

https://gerrit.wikimedia.org/r/965534

gerritbot added a comment.Oct 17 2023, 12:18 PM

Change 966238 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/AdvancedSearch@wmf/1.42.0-wmf.1] Workaround to center search terms label

https://gerrit.wikimedia.org/r/966238

gerritbot added a comment.Oct 17 2023, 12:23 PM

Change 966238 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@wmf/1.42.0-wmf.1] Workaround to center search terms label

https://gerrit.wikimedia.org/r/966238

WMDE-Fisch moved this task from Review to Done on the WMDE-TechWish-Maintenance-2023 board.Oct 17 2023, 12:35 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 17 2023, 1:00 PM
gerritbot added a comment.Oct 18 2023, 7:17 AM

Change 961776 abandoned by Mareike Heuer:

[mediawiki/extensions/AdvancedSearch@master] Fix misaligned namespace pillbox is AdvancedSearch

Reason:

https://gerrit.wikimedia.org/r/961776

Maintenance_bot removed a project: Patch-For-Review.Oct 18 2023, 7:30 AM
gerritbot added a comment.Oct 18 2023, 8:23 AM

Change 966610 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/AdvancedSearch@wmf/1.42.0-wmf.1] Revert "Revert "Workaround to center search terms label""

https://gerrit.wikimedia.org/r/966610

gerritbot added a project: Patch-For-Review.Oct 18 2023, 8:23 AM
WMDE-Fisch moved this task from Done to Review on the WMDE-TechWish-Maintenance-2023 board.Oct 18 2023, 2:00 PM
gerritbot added a comment.Oct 19 2023, 1:40 PM

Change 966610 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@wmf/1.42.0-wmf.1] Revert "Revert "Workaround to center search terms label""

https://gerrit.wikimedia.org/r/966610

Stashbot added a comment.Oct 19 2023, 1:41 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-19T13:41:00Z] <wmde-fisch@deploy2002> Started scap: Backport for [[gerrit:966610|Revert "Revert "Workaround to center search terms label"" (T252346)]]

Stashbot added a comment.Oct 19 2023, 1:42 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-19T13:42:32Z] <wmde-fisch@deploy2002> wmde-fisch: Backport for [[gerrit:966610|Revert "Revert "Workaround to center search terms label"" (T252346)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Oct 19 2023, 1:48 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-19T13:48:50Z] <wmde-fisch@deploy2002> Finished scap: Backport for [[gerrit:966610|Revert "Revert "Workaround to center search terms label"" (T252346)]] (duration: 07m 50s)

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.1; 2023-10-17); removed MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 19 2023, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 19 2023, 2:10 PM
lilients_WMDE moved this task from Review to Done on the WMDE-TechWish-Maintenance-2023 board.Oct 20 2023, 8:58 AM
thiemowmde moved this task from Backlog to In progress on the WMDE-TechWish-Maintenance board.Oct 20 2023, 9:03 AM
WMDE-Fisch closed this task as Resolved.Oct 25 2023, 12:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits