wikimedia-mobile-terms url should be removed or renamed and updated to mobile-frontend-terms-url
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Nikerabbit
	May 11 2020, 8:43 AM

Description

The messages wikimedia-mobile-terms contains link to https://m.foundation.wikimedia.org/wiki/Terms_of_Use which does not work. I could not find the message used anywhere in the interface, so maybe the code at https://codesearch.wmflabs.org/search/?q=getTermsLink&i=nope&files=&repos= is broken.

The message that is used is mobile-frontend-terms-url . This is set for certain projects, but not all projects as some projects e.g. mediawiki.org do not set the message.

It's unclear whether this is up to the projects to update or whether there should be a generic catch all message in WikimediaMessages. if the former we should delete it. If the latter we should rename.

Proposed fix

rename the message key wikimedia-mobile-terms in WikimediaMessages to mobile-frontend-terms-url
Update value to https://foundation.wikimedia.org/wiki/Terms_of_Use

QA steps

on m.mediawiki.org a terms of use link should appear in the footer

QA Results - Prod

AC	Status	Details
1	❌	T252375#6215935

Details

	Subject	Repo	Branch	Lines +/-
	Restore terms of use link URL to wikis	mediawiki/extensions/WikimediaMessages	master	+51 -42

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Varnent	T188774 Launch of new Wikimedia Foundation website (Tracking task)
Resolved	Varnent	T205345 Repurposing of Foundation wiki as Governance wiki (Tracking task)
Resolved	None	T188776 Move Foundation Wiki to new URL when new Wikimedia Foundation website launches
Resolved	Reedy	T199808 Update portals to cater for foundationwiki move
Resolved	Varnent	T199812 Update wikimediafoundation.org to foundation.wikimedia.org across numerous repos
Resolved	bd808	T201890 Update data in `meta_p.wiki` in Cloud Services for foundationwiki move
		Restricted Task
Resolved	Jdrewniak	T252375 wikimedia-mobile-terms url should be removed or renamed and updated to mobile-frontend-terms-url

Event Timeline

Nikerabbit created this task.May 11 2020, 8:43 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2020, 8:43 AM

Not use by MobileFrontend. Maybe apps?
We use mobile-frontend-terms-url

Jdlrobson added projects: Android-app-Bugs, iOS-app-Bugs.May 11 2020, 3:23 PM

Restricted Application added projects: Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog. · View Herald TranscriptMay 11 2020, 3:23 PM

Judging by its introduction in fc693fe9ab47a462465510f0b45ce4c4e3cc245e and use of a hook that no longer exists/runs, pretty sure this is unused. We might want to rename it to mobile-frontend-terms-url but given there is no terms of use on mediawiki.org (by design or mistake?) maybe this message should be renamed? https://m.mediawiki.org/wiki/MediaWiki:Mobile-frontend-terms-url

Checked - Android doesn't use it either.

• Charlotte removed projects: Wikipedia-Android-App-Backlog, Android-app-Bugs.May 11 2020, 4:22 PM

Jdlrobson awarded a token.May 11 2020, 4:58 PM

This string is not used by the iOS app.

LGoto removed projects: iOS-app-Bugs, Wikipedia-iOS-App-Backlog.May 11 2020, 6:36 PM

Legal - could you please advise if its intentional that the terms of use is linked to from the footer of en.m.wikipedia.org but not m.mediawiki.org ?

@Jdlrobson: WMF-Legal will likely not reply here, see https://phabricator.wikimedia.org/project/profile/28/

Jdlrobson renamed this task from wikimedia-mobile-terms url is broken and maybe unused to wikimedia-mobile-terms url should be removed or renamed and updated to mobile-frontend-terms-url .May 11 2020, 8:35 PM

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-2019-20-Q4).

Jdlrobson updated the task description. (Show Details)

• Charlotte unsubscribed.May 12 2020, 10:33 AM

Jdlrobson moved this task from Needs triage to Triaged on the Mobile board.May 14 2020, 9:41 PM

Moving back to backlog until we can get guidance from legal

ovasileva moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.May 20 2020, 10:07 AM

No, that's unintentional. The correct Terms of Use link should be in the footer.

Jdlrobson added a project: patch-welcome.May 20 2020, 10:27 PM

Jdlrobson updated the task description. (Show Details)

Change 599402 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/WikimediaMessages@master] Restore terms of link URL to wikis

https://gerrit.wikimedia.org/r/599402

gerritbot added a project: Patch-For-Review.May 28 2020, 6:23 PM

A missing terms of use seems pretty high priority to fix @ovasileva ?

[…] to https://m.foundation.wikimedia.org/wiki/Terms_of_Use which does not work.

Indeed, on mobile the for this goes to https://foundation.m.wikimedia.org/wiki/Terms_of_Use instead. The m-dot is generally in the middle except for domains where there is no subdomain (e.g. m.wikidata.org, m.mediawiki.org).

This was broken by T199812, which blindly changed wikimediafoundation.org to foundation.wikimedia.org, thus breaking the m.wikimediafoundation.org urls.

Krinkle added a parent task: T199812: Update wikimediafoundation.org to foundation.wikimedia.org across numerous repos.May 28 2020, 6:43 PM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Jun 1 2020, 10:05 PM

ovasileva set the point value for this task to 2.Jun 3 2020, 4:15 PM

ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.

Jdlrobson moved this task from Ready for Development to Needs More Work on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Jun 4 2020, 2:26 PM

Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Jun 4 2020, 2:29 PM

• JMinor unsubscribed.Jun 4 2020, 3:33 PM

Jdlrobson added a parent task: Restricted Task.Jun 5 2020, 3:54 PM

Jdlrobson assigned this task to Jdrewniak.Jun 8 2020, 5:10 PM

Change 599402 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] Restore terms of use link URL to wikis

https://gerrit.wikimedia.org/r/599402

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2020, 11:10 AM

We'll want to check this shows up on mediawiki.org when this change has rolled out.

Jdlrobson reassigned this task from Jdrewniak to Edtadros.Jun 9 2020, 5:03 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a subscriber: Jdrewniak.

Test Result - Prod

Status: ❌ Fail
Environment: m.mediawiki.org
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA steps

❌ AC1: On m.mediawiki.org a terms of use link should appear in the footer

m.mediawiki.org_wiki_MediaWiki(iPhone X).png (2×1 px, 184 KB)

NOTE: The terms of use link does appear if I toggle to Desktop and back again to Mobile. I also tried a hard reload and it still didn't make the link appear.

Edtadros updated the task description. (Show Details)Jun 11 2020, 4:34 PM

Hmm.. I'm seeing:

Screen Shot 2020-06-11 at 9.41.20 AM.png (430×870 px, 54 KB)

Jdlrobson moved this task from Needs More Work to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Jun 11 2020, 5:09 PM

Saw it as well once I cleared the cache. Resolving!

MarcoAurelio moved this task from Backlog to Closed on the WikimediaMessages board.Aug 31 2020, 10:41 AM

	F31861775: Screen Shot 2020-06-11 at 9.41.20 AM.png
	Jun 11 2020, 4:41 PM

	F31861768: m.mediawiki.org_wiki_MediaWiki(iPhone X).png
	Jun 11 2020, 4:32 PM

wikimedia-mobile-terms url should be removed or renamed and updated to mobile-frontend-terms-url Closed, ResolvedPublic2 Estimated Story PointsActions

Description

Proposed fix

QA steps

QA Results - Prod

Details

Related ObjectsSearch...

Event Timeline

Test Result - Prod

QA steps

wikimedia-mobile-terms url should be removed or renamed and updated to mobile-frontend-terms-url
Closed, ResolvedPublic2 Estimated Story Points
Actions

Related Objects
Search...