Page MenuHomePhabricator
Create Task
Maniphest T252409

Rewrite HtmlPageLinkRendererBeginHookHandler::doHtmlPageLinkRendererBegin to primarily use EntityIds
Closed, ResolvedPublic
Actions

Description

From the task breakdown on 11 May T249836#6124657

In T252407 we introduce a new service that can go from a Title to EntityId.
We should use that right at the start of the hook and then use the EntityId object for the rest of the hooks logic.

This will include using some of the other services introduced by federated properties for various title related actions.
This will also include the need to alter DefaultEntityLinkFormatter to not use Title, instead use and EntityId and EntityTitleTextLookup

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikibaseLexememaster+10 -51Lexeme/FormLinkFormatter::getTitleAttribute: use EntityId
mediawiki/extensions/Wikibasemaster+128 -18EntityLinkFormatter::getTitleAttribute: allow only EntityId
mediawiki/extensions/WikibaseLexememaster+7 -3Fix phan after changes in Wikibase
mediawiki/extensions/Wikibasemaster+1 K -1 KHtmlPageLinkRendererBeginHookHandler: move to HtmlPageLinkRendererEnd
mediawiki/extensions/WikibaseLexememaster+93 -16Adjust lexeme related EntityLinkFormatter implementations
mediawiki/extensions/WikibaseCirrusSearchmaster+1 -2CirrusShowSearchHitHandler: Use EntityLinkFormatterFactory
mediawiki/extensions/Wikibasemaster+1 -1EntityLinkFormatterFactory can be used as factory for default formatter
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Addshore created this task.May 11 2020, 1:35 PM
• Addshore moved this task from Backlog to Ready to estimate on the Wikibase - Federated Properties board.May 12 2020, 2:14 PM
Samantha_Alipio_WMDE moved this task from Ready to estimate to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.May 18 2020, 8:33 AM
Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Sprint 6/6 (Hike 1)); removed Wikibase - Federated Properties.
Rosalie_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 6/6 (Hike 1)) board.May 18 2020, 1:01 PM
Rosalie_WMDE claimed this task.May 19 2020, 8:14 AM
gerritbot added a comment.May 26 2020, 6:08 AM

Change 598574 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] [WIP]Rewrite HtmlPageLinkRendererBeginHookHandler::doHtmlPageLinkRendererBegin to primarily use EntityIds

https://gerrit.wikimedia.org/r/598574

gerritbot added a project: Patch-For-Review.May 26 2020, 6:08 AM
WMDE-leszek added a subscriber: WMDE-leszek.May 29 2020, 1:10 PM
Rosalie_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 6/6 (Hike 1)) board.May 29 2020, 3:14 PM
gerritbot added a comment.Jun 2 2020, 4:42 PM

Change 601794 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] [WIP]FP: Rewrite HtmlPageLinkRendererBeginHookHandler::doHtmlPageLinkRendererBegin to primarily use EntityIds

https://gerrit.wikimedia.org/r/601794

gerritbot added a comment.Jun 4 2020, 2:39 PM

Change 602380 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] EntityLinkFormatterFactory can be used as factory for default formatter

https://gerrit.wikimedia.org/r/602380

gerritbot added a comment.Jun 4 2020, 2:42 PM

Change 602383 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseCirrusSearch@master] CirrusShowSearchHitHandler: Use EntityLinkFormatterFactory

https://gerrit.wikimedia.org/r/602383

gerritbot added a comment.Jun 4 2020, 3:43 PM

Change 602380 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EntityLinkFormatterFactory can be used as factory for default formatter

https://gerrit.wikimedia.org/r/602380

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 4 2020, 4:00 PM
gerritbot added a comment.Jun 4 2020, 7:15 PM

Change 602383 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] CirrusShowSearchHitHandler: Use EntityLinkFormatterFactory

https://gerrit.wikimedia.org/r/602383

Jakob_WMDE mentioned this in rEWCS11feab0f5326: CirrusShowSearchHitHandler: Use EntityLinkFormatterFactory.Jun 4 2020, 7:17 PM
Rosalie_WMDE removed Rosalie_WMDE as the assignee of this task.Jun 5 2020, 7:29 AM
Rosalie_WMDE added a subscriber: Rosalie_WMDE.
gerritbot added a comment.Jun 5 2020, 3:47 PM

Change 602721 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] DefaultEntityLinkFormatter: allow only EntityId

https://gerrit.wikimedia.org/r/602721

gerritbot added a comment.Jun 5 2020, 4:26 PM

Change 602735 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Lexeme/FormLinkFormatter::getTitleAttribute: use EntityId

https://gerrit.wikimedia.org/r/602735

gerritbot added a comment.Jun 5 2020, 4:54 PM

Change 601794 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Adjust lexeme related EntityLinkFormatter implementations

https://gerrit.wikimedia.org/r/601794

gerritbot added a comment.Jun 5 2020, 5:23 PM

Change 598574 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] HtmlPageLinkRendererBeginHookHandler: move to HtmlPageLinkRendererEnd

https://gerrit.wikimedia.org/r/598574

gerritbot added a comment.Jun 5 2020, 6:44 PM

Change 602757 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] Fix phan after changes in Wikibase

https://gerrit.wikimedia.org/r/602757

gerritbot added a comment.Jun 5 2020, 9:27 PM

Change 602757 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix phan after changes in Wikibase

https://gerrit.wikimedia.org/r/602757

gerritbot added a comment.Jun 5 2020, 11:07 PM

Change 602721 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EntityLinkFormatter::getTitleAttribute: allow only EntityId

https://gerrit.wikimedia.org/r/602721

DannyS712 mentioned this in T254701: Tests failing for the master branch of WikibaseLexeme.Jun 8 2020, 1:31 AM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase - Federated Properties (Sprint 6/6 (Hike 1)) board.Jun 8 2020, 7:39 AM
gerritbot added a comment.Jun 8 2020, 9:57 AM

Change 602735 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Lexeme/FormLinkFormatter::getTitleAttribute: use EntityId

https://gerrit.wikimedia.org/r/602735

Maintenance_bot removed a project: Patch-For-Review.Jun 8 2020, 10:10 AM
Samantha_Alipio_WMDE closed this task as Resolved.Jun 9 2020, 8:52 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL