Page MenuHomePhabricator

Handle large datasets in JSON edit dialog for tabular data pages
Open, Needs TriagePublic

Description

The edit dialog currently does not handle datasets with more than 5000 data cells in the table. This is because it becomes too slow, probably due to the number of TextInputWidgets appended to the page (one for each data cell).

Lazy-load only the TextInputWidgets in view, and if this improves performance, remove the size limit for the edit dialog.

Event Timeline

One strategy I often see in table editors (both on the Web and on native platforms) is to maintain only a single input field and move it around to cover the selected cell. (On Apple platforms, this is called the “field editor”.) Unselected cells are otherwise just plain text. That keeps things lightweight even for large tables and makes it more straightforward to swap in other kinds of input fields depending on the data type.