| dbarratt | |
| May 12 2020, 1:18 AM |
| F31858058: fine.png | |
| Jun 8 2020, 4:14 PM |
| F31835881: blank_log.png | |
| May 21 2020, 3:29 PM |
Problem
TimelineRowFormatter currently uses Title and SpecialPage singletons which make testing more difficult.
Proposed Solution
Replace instances of Title with TitleValue and use the TitleFormatter and SpecialPageFactory services to do the tasks that were previously accomplished by the singletons.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Replace Title with TitleValue and SpecialPage with SpecialPageFactory | mediawiki/extensions/CheckUser | master | +54 -11 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T139810 RFC: Overhaul the CheckUser extension | |||
| Resolved | Niharika | T236225 [Epic] CheckUser 2.0 Improvements | |||
| Resolved | Niharika | T237595 CU 2.0: Timeline tab | |||
| Resolved | dmaza | T247641 CU 2.0: Add variant display to the Timeline result list | |||
| Resolved | Tchanders | T252695 Update Structured Discussions Implementation of SpecialCheckUserGetLinksFromRow to CheckUserGetLinksFromRow | |||
| Resolved | Tchanders | T252031 Make TimelineRowFormatter::getLinks do the same checks as it is currently done in SpecialCheckUser | |||
| Resolved | dbarratt | T252485 Use TitleFormatter and SpecialPageFactory |
Change 595795 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Replace Title with TitleValue and SpecialPage with SpecialPageFactory
Change 595795 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Replace Title with TitleValue and SpecialPage with SpecialPageFactory
@dbarratt I am finding that I don't see the "(Logs)" link for the log action "reset password". Possibly because it has a blank cuc_title in cu_changes?
So it looks like we don't record a logid for logged actions in CheckUser. Since we don't, the only thing we could link to is the log for that user (with all of their logged actions), which doesn't seem very helpful. :/
Great.
I think the issue with the leading ". ." in T252485#6155656 was fixed by T252031, so rows where there is no "(Log)" link begin with the timestamp.
Otherwise, all the links work as they did before.