Page MenuHomePhabricator

Standardize on OOUI message box styles
Open, Needs TriagePublic

Description

Needs discussion.

Proposal: Any direct usages for example of the warningbox style should be replaced with an OOUI widget.

Event Timeline

awight created this task.May 12 2020, 8:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2020, 8:08 AM

Change 595897 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Remove some unused CSS

https://gerrit.wikimedia.org/r/595897

[…] Once T250893 and T250501 are resolved, there will be one remaining usage […]

I seriously don't get what this ticket talks about. It sounds like we had 3 usages before, and removing 2 of them would leave 1. But where? There is none: https://codesearch.wmflabs.org/search/?q=mw-twocolconflict-split-warningbox.

awight renamed this task from Remove custom warningbox style to Standardize on OOUI message box styles.May 12 2020, 11:40 AM
awight updated the task description. (Show Details)

[…] Once T250893 and T250501 are resolved, there will be one remaining usage […]

I seriously don't get what this ticket talks about. It sounds like we had 3 usages before, and removing 2 of them would leave 1. But where? There is none: https://codesearch.wmflabs.org/search/?q=mw-twocolconflict-split-warningbox.

This was caused by my misreading: our twocolconflict custom warningbox style is unused now. But we still directly refer to MediaWiki core warningbox style, so I've changed the task to reflect this.

Change 595897 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Remove some unused CSS

https://gerrit.wikimedia.org/r/595897