Page MenuHomePhabricator
Create Task
Maniphest T252505

Standardize on OOUI message box styles
Open, Needs TriagePublic
Actions

Description

Needs discussion.

Proposal: Any direct usages for example of the warningbox style should be replaced with an OOUI widget.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/TwoColConflictmaster+0 -13Remove some unused CSS
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.May 12 2020, 8:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2020, 8:08 AM
gerritbot added a comment.May 12 2020, 11:02 AM

Change 595897 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Remove some unused CSS

https://gerrit.wikimedia.org/r/595897

gerritbot added a project: Patch-For-Review.May 12 2020, 11:02 AM
thiemowmde added a subscriber: thiemowmde.May 12 2020, 11:03 AM

[…] Once T250893 and T250501 are resolved, there will be one remaining usage […]

I seriously don't get what this ticket talks about. It sounds like we had 3 usages before, and removing 2 of them would leave 1. But where? There is none: https://codesearch.wmflabs.org/search/?q=mw-twocolconflict-split-warningbox.

awight renamed this task from Remove custom warningbox style to Standardize on OOUI message box styles.May 12 2020, 11:40 AM
awight updated the task description. (Show Details)
In T252505#6128848, @thiemowmde wrote:

[…] Once T250893 and T250501 are resolved, there will be one remaining usage […]

I seriously don't get what this ticket talks about. It sounds like we had 3 usages before, and removing 2 of them would leave 1. But where? There is none: https://codesearch.wmflabs.org/search/?q=mw-twocolconflict-split-warningbox.

This was caused by my misreading: our twocolconflict custom warningbox style is unused now. But we still directly refer to MediaWiki core warningbox style, so I've changed the task to reflect this.

gerritbot added a comment.May 12 2020, 11:46 AM

Change 595897 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Remove some unused CSS

https://gerrit.wikimedia.org/r/595897

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 12 2020, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 12 2020, 12:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL