Page MenuHomePhabricator

Tour popups should never overlap one another
Closed, ResolvedPublic1 Estimated Story Points

Description

Our guided tour popups were capable of this annoying behavior:


Before opening a new popup, always close any currently open popups.

Event Timeline

awight created this task.May 12 2020, 9:48 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2020, 9:48 AM

Change 595864 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/TwoColConflict@master] Always close popups before opening a new one

https://gerrit.wikimedia.org/r/595864

awight moved this task from Backlog to Tickets in sprint on the Two-Column-Edit-Conflict-Merge board.
awight set the point value for this task to 1.
awight added a subscriber: ECohen_WMDE.
awight removed awight as the assignee of this task.May 12 2020, 9:52 AM

What exactly is the behavior that you are including in this ticket? There are a few different options as I see it. From what I've seen elsewhere on WP, the standard interaction seems to be that if someone clicks out of the tooltip or on another blue dot, then the current one closes but the dot does not disappear so it can be reopened later.

Are you also including closing/keeping dot, if someone presses esc? If someone clicks out/any where else on the page?

In T252517#6128696, @ecohen wrote:

What exactly is the behavior that you are including in this ticket?

Thanks for asking! The status quo is:

  • Clicking on a blue dot makes the dot disappear, and shows the corresponding popup.
  • Clicking on the "Okay, got it" button makes the popup disappear.
  • <esc> key does nothing.
  • Clicking outside the popup does nothing.
  • Clicking in another blue dot leaves any open popups unchanged, and shows the next popup.

The change I've proposed so far, which the uploaded patch will implement, only affects the last point:

  • Clicking in a blue dot will close any open popups before showing the next.

Ok makes sense - so it partially solves the problem by addressing the weirdest part first (overlapping tooltips). Thanks for the explanation!

In the new changes, when the popup closes, is the blue dot also gone?

In T252517#6128782, @ecohen wrote:

In the new changes, when the popup closes, is the blue dot also gone?

Exactly. If the user clicks blue dots A and then B, then blue dot A disappears as soon at it's clicked, and remains hidden. Blue dot B disappears when it's clicked.

Change 595864 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Always close popups before opening a new one

https://gerrit.wikimedia.org/r/595864

thiemowmde closed this task as Resolved.May 13 2020, 11:57 AM