Replace inline CSS style attributes with a proper CSS module in DoubleWiki
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Tacsipacsi
	May 12 2020, 11:54 AM

Description

DoubleWiki currently uses a mixture of inline style attributes and deprecated presentational HTML attributes (width, valign etc.) for styling its output. It should use classes and ResourceLoader CSS modules instead.

Acceptance Criteria

A CSS/LESS ResourceLoader module is created containing all the styling needed for the extension (probably plain CSS is enough here).
DoubleWiki.php loads that module using OutputPage::addModuleStyles if the extension will certainly output something (i.e. in line 89).
No inline CSS or presentational attributes remain in DoubleWiki.php.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Replacing inline CSS style with a stylesheet	mediawiki/extensions/DoubleWiki	master	+49 -13

Customize query in gerrit

Related Objects

Mentioned In: T89561: Implement a CSS preprocessor for direction flipping based on the content direction
Mentioned Here: T344544: Archive the DoubleWiki extension

Event Timeline

Tacsipacsi created this task.May 12 2020, 11:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2020, 11:54 AM

Aklapper renamed this task from Use CSS in DoubleWiki to Replace inline CSS style attributes with a proper CSS module in DoubleWiki.May 12 2020, 2:01 PM

Hi All, I would like to work on this task

Hi and welcome, feel free to do so. :)

@Prernaswarna Feel free to ask any questions about the task if you need help...

I appreciate that. Thank you!

@Prernaswarna: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task, or do you need any help? Thanks!

Hi I will not be able to work on this task. Sorry

Khr2003 claimed this task.Mar 20 2021, 8:44 AM

@Aklapper Will it be fine to also change table container to flex layout since it is more modern and the data presented is not tabular.

@Khr2003: I cannot answer that as I'm not a maintainer, sorry :)

@Khr2003 I'd say stick with table for now, Wikimedia tends to support a lot of really old browsers (think IE8,9), so it's probably not the best idea to break compatibility all of a sudden

Change 673696 had a related patch set uploaded (by Khr2003; owner: Khr2003):
[mediawiki/extensions/DoubleWiki@master] Replacing inline CSS style with a stylesheet

https://gerrit.wikimedia.org/r/673696

gerritbot added a project: Patch-For-Review.Mar 20 2021, 1:25 PM

@Aklapper No problem.

@Soda I updated the repo. Please let me know if there are more changes to be done.

Diptendubiswas subscribed.Apr 14 2021, 9:04 PM

i want to do this task please give me this task , if yes then reply as soon as possible

@Ankur0710: Hi and welcome! Please check https://www.mediawiki.org/wiki/New_Developers#Some_general_communication_tips - thanks!

Also note that this task already has a patch in Gerrit by @Khr2003 which welcomes rework. See https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_.28your_own_or_someone_else.27s.29 if anyone is interested in that.

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Mar 12 2022, 9:37 PM

Tacsipacsi mentioned this in T89561: Implement a CSS preprocessor for direction flipping based on the content direction.Mar 13 2022, 12:16 AM

@Khr2003: Per emails from Sep18 and Oct20 and https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup , I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action... → Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

The unmaintained MediaWiki-extensions-DoubleWiki extension has been undeployed from Wikimedia servers and may get archived thus setting Priority to Low.

Aklapper removed a project: good first task.Nov 23 2023, 5:02 PM