Page MenuHomePhabricator

OAuth extension error messages are missing spaces
Closed, ResolvedPublicBUG REPORT

Description

Two hard-coded error messages in the OAuth extension are missing a space, causing the client identifier and the error message to run together:

https://gerrit.wikimedia.org/g/mediawiki/extensions/OAuth/+/45bff8f0b6ceb54588f76f5e88c2b9e89fef94c8/src/Entity/AccessTokenEntity.php#145

https://gerrit.wikimedia.org/g/mediawiki/extensions/OAuth/+/45bff8f0b6ceb54588f76f5e88c2b9e89fef94c8/src/AuthorizationProvider/Grant/AuthorizationCodeAuthorization.php#57

This can be trivially fixed by adding a space before the word "is" in the message string.

Event Timeline

BPirkle created this task.May 12 2020, 7:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2020, 7:47 PM
BPirkle triaged this task as Low priority.May 12 2020, 7:47 PM
Tks4Fish claimed this task.May 13 2020, 3:00 AM

Change 596086 had a related patch set uploaded (by Tks4Fish; owner: Tks4Fish):
[mediawiki/extensions/OAuth@master] Adding blankspace per task

https://gerrit.wikimedia.org/r/596086

Change 596086 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] Adding blankspace per task

https://gerrit.wikimedia.org/r/596086

BPirkle closed this task as Resolved.May 13 2020, 3:13 PM

Looks great, thanks!