Page MenuHomePhabricator
Create Task
Maniphest T252589

Strengthen "config" schema validation in manifest_version 2
Closed, ResolvedPublic
Actions

Description

I noticed a few places (AbuseFilter, SiteMatrix) used the old _merge_strategy key where the unprefixed version should've been used. And descriptionmsg was spelled wrong in the schema.

We need to tighten up the schema validation by setting additionalProperties: false. This causes failures in a few extensions, but it's all straightforward (plus T252586).

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.May 12 2020, 7:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2020, 7:48 PM
gerritbot added a comment.May 12 2020, 7:50 PM

Change 596039 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/BlueSpiceArticlePreviewCapture@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596039

gerritbot added a project: Patch-For-Review.May 12 2020, 7:50 PM

Change 596040 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/BlueSpiceFoundation@master] Merge doc notes into "description" key in extension.json

https://gerrit.wikimedia.org/r/596040

gerritbot added a comment.May 12 2020, 7:51 PM

Change 596041 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/BlueSpicePageTemplates@master] Use correct "descriptionmsg" property

https://gerrit.wikimedia.org/r/596041

gerritbot added a comment.May 12 2020, 7:52 PM

Change 596042 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/BlueSpiceVisualEditorConnector@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596042

gerritbot added a comment.May 12 2020, 7:52 PM

Change 596043 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/GlobalUsage@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596043

gerritbot added a comment.May 12 2020, 7:53 PM

Change 596044 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/MediaWikiAuth@master] Use correctly spelled "descriptionmsg" in extension.json

https://gerrit.wikimedia.org/r/596044

gerritbot added a comment.May 12 2020, 7:53 PM

Change 596045 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/PageImages@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596045

gerritbot added a comment.May 12 2020, 7:56 PM

Change 596047 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/WebDAV@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596047

gerritbot added a comment.May 12 2020, 7:58 PM

Change 596048 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Variables@master] Remove example from extension.json

https://gerrit.wikimedia.org/r/596048

gerritbot added a comment.May 12 2020, 8:00 PM

Change 596050 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/skins/BlueSpiceCalumma@master] Use "description" in skin.json

https://gerrit.wikimedia.org/r/596050

gerritbot added a comment.May 12 2020, 8:05 PM

Change 596053 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] registration: Restrict properties in "config" in manifest_version 2

https://gerrit.wikimedia.org/r/596053

gerritbot added a comment.May 12 2020, 8:05 PM

Change 596039 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceArticlePreviewCapture@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596039

gerritbot added a comment.May 12 2020, 8:05 PM

Change 596040 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Merge doc notes into "description" key in extension.json

https://gerrit.wikimedia.org/r/596040

gerritbot added a comment.May 12 2020, 8:05 PM

Change 596043 merged by jenkins-bot:
[mediawiki/extensions/GlobalUsage@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596043

gerritbot added a comment.May 12 2020, 8:05 PM

Change 596044 merged by jenkins-bot:
[mediawiki/extensions/MediaWikiAuth@master] Use correctly spelled "descriptionmsg" in extension.json

https://gerrit.wikimedia.org/r/596044

gerritbot added a comment.May 12 2020, 8:13 PM

Change 596047 merged by jenkins-bot:
[mediawiki/extensions/WebDAV@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596047

gerritbot added a comment.May 12 2020, 8:13 PM

Change 596045 merged by jenkins-bot:
[mediawiki/extensions/PageImages@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596045

gerritbot added a comment.May 12 2020, 8:13 PM

Change 596042 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceVisualEditorConnector@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596042

gerritbot added a comment.May 12 2020, 8:13 PM

Change 596041 merged by jenkins-bot:
[mediawiki/extensions/BlueSpicePageTemplates@master] Use correct "descriptionmsg" property

https://gerrit.wikimedia.org/r/596041

gerritbot added a comment.May 12 2020, 8:13 PM

Change 596050 merged by jenkins-bot:
[mediawiki/skins/BlueSpiceCalumma@master] Use "description" in skin.json

https://gerrit.wikimedia.org/r/596050

Legoktm mentioned this in rMSBC9aedd77db005: Use "description" in skin.json.May 12 2020, 8:26 PM
Legoktm mentioned this in rEBUA2a6533db4e87: Use "description" in extension.json.May 12 2020, 8:28 PM
Legoktm mentioned this in rEBSLc9a68d0e43e7: Use correct "descriptionmsg" property.May 12 2020, 8:33 PM
Legoktm mentioned this in rEWDVd290737386f1: Use "description" in extension.json.May 12 2020, 8:47 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 12 2020, 9:00 PM
Legoktm mentioned this in rEMWAa2aecf9eb4ed: Use correctly spelled "descriptionmsg" in extension.json.May 12 2020, 9:04 PM
gerritbot added a comment.Jul 8 2020, 8:59 AM

Change 596048 merged by Legoktm:
[mediawiki/extensions/Variables@master] Move config example to descriptionmsg

https://gerrit.wikimedia.org/r/596048

gerritbot added a comment.Jul 14 2020, 9:40 AM

Change 596053 merged by jenkins-bot:
[mediawiki/core@master] registration: Restrict properties in "config" in manifest_version 2

https://gerrit.wikimedia.org/r/596053

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 14 2020, 10:00 AM
Legoktm closed this task as Resolved.Jul 21 2020, 8:41 AM
Legoktm claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits