Page MenuHomePhabricator

Strengthen "config" schema validation in manifest_version 2
Closed, ResolvedPublic

Description

I noticed a few places (AbuseFilter, SiteMatrix) used the old _merge_strategy key where the unprefixed version should've been used. And descriptionmsg was spelled wrong in the schema.

We need to tighten up the schema validation by setting additionalProperties: false. This causes failures in a few extensions, but it's all straightforward (plus T252586).

Event Timeline

Change 596039 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/BlueSpiceArticlePreviewCapture@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596039

Change 596040 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/BlueSpiceFoundation@master] Merge doc notes into "description" key in extension.json

https://gerrit.wikimedia.org/r/596040

Change 596041 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/BlueSpicePageTemplates@master] Use correct "descriptionmsg" property

https://gerrit.wikimedia.org/r/596041

Change 596042 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/BlueSpiceVisualEditorConnector@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596042

Change 596043 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/GlobalUsage@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596043

Change 596044 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/MediaWikiAuth@master] Use correctly spelled "descriptionmsg" in extension.json

https://gerrit.wikimedia.org/r/596044

Change 596045 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/PageImages@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596045

Change 596047 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/WebDAV@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596047

Change 596048 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Variables@master] Remove example from extension.json

https://gerrit.wikimedia.org/r/596048

Change 596050 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/skins/BlueSpiceCalumma@master] Use "description" in skin.json

https://gerrit.wikimedia.org/r/596050

Change 596053 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] registration: Restrict properties in "config" in manifest_version 2

https://gerrit.wikimedia.org/r/596053

Change 596039 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceArticlePreviewCapture@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596039

Change 596040 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Merge doc notes into "description" key in extension.json

https://gerrit.wikimedia.org/r/596040

Change 596043 merged by jenkins-bot:
[mediawiki/extensions/GlobalUsage@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596043

Change 596044 merged by jenkins-bot:
[mediawiki/extensions/MediaWikiAuth@master] Use correctly spelled "descriptionmsg" in extension.json

https://gerrit.wikimedia.org/r/596044

Change 596047 merged by jenkins-bot:
[mediawiki/extensions/WebDAV@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596047

Change 596045 merged by jenkins-bot:
[mediawiki/extensions/PageImages@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596045

Change 596042 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceVisualEditorConnector@master] Use "description" in extension.json

https://gerrit.wikimedia.org/r/596042

Change 596041 merged by jenkins-bot:
[mediawiki/extensions/BlueSpicePageTemplates@master] Use correct "descriptionmsg" property

https://gerrit.wikimedia.org/r/596041

Change 596050 merged by jenkins-bot:
[mediawiki/skins/BlueSpiceCalumma@master] Use "description" in skin.json

https://gerrit.wikimedia.org/r/596050

Change 596048 merged by Legoktm:
[mediawiki/extensions/Variables@master] Move config example to descriptionmsg

https://gerrit.wikimedia.org/r/596048

Change 596053 merged by jenkins-bot:
[mediawiki/core@master] registration: Restrict properties in "config" in manifest_version 2

https://gerrit.wikimedia.org/r/596053

Legoktm claimed this task.