Page MenuHomePhabricator

Debian-glue doesn't check for the validity of the distribution in the changelog.
Open, LowPublic

Description

See for instance https://integration.wikimedia.org/ci/job/debian-glue-backports/90/console

The error is

09:25:57 I: Building the build environment
09:25:57 I: running debootstrap
09:25:57 /usr/sbin/debootstrap
09:25:57 E: /srv/pbuilder/aptcache/butster-amd64: No such directory
09:25:57 E: debootstrap failed
09:25:57 E: debootstrap.log not present
09:25:57 W: Aborting with an error
09:25:57 E: pbuilder create failed

(see "buTster").

I tested for a command injection but thankfully we run debian-parsechangelog before we inject what we extract from the distro-line to feed to pbuilder.

The error message, as you can see, is quite confusing. I think we should check whatever distro we find in dch against a list of known distributions and send a clear error otherwise.

Related Objects

Event Timeline

Joe created this task.May 13 2020, 7:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2020, 7:42 AM
Joe triaged this task as High priority.May 13 2020, 7:42 AM

Setting priority as "high" as this is blocking a project.

Joe lowered the priority of this task from High to Low.May 13 2020, 7:48 AM

I just realized, the problem is the typo buTster I made in the commit. So changing the priority accordingly, I'll rewrite the text of the bug as the problem is different :)

Joe renamed this task from Jobs using "debian-glue" on buster fail consistently to Debian-glue doesn't check for the validity of the distribution in the changelog..May 13 2020, 7:53 AM
Joe updated the task description. (Show Details)
Joe updated the task description. (Show Details)May 13 2020, 8:09 AM