Page MenuHomePhabricator

Editing multiple references in a row disables the Edit button
Open, Needs TriagePublic

Description

If I edit several references (citations) in a row in VisualEditor, eventually the Edit button (in the References dialog) fails to work. I will attach a video of the problem in action.

The following normal sequence of operations succeeds for a while, but eventually step 2 fails.

  1. Click the next reference. The references dialog appears.
  2. Click the Edit button.
  3. Edit the reference and make a change.
  4. Click Apply Changes.

In the attached video, I click on references 10, 11, and 12 in succession and edit them successfully. But when I get to reference 13, I place the mouse pointer on the Edit button and click, but the References dialog just disappears. I then click reference 13 again and the Edit button works.

This problem is intermittent but happens frequently on my MediaWiki 1.34.1 setup.

It is possible that the page needs a decent number of references before the problem shows up. I tried a page with just 7 references but could not make the problem happen. My test page has 28 references.

It's also possible that the <ref> tags need to be all in a row, next to each other, with no spaces between, as in the video.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This is a screencast of the problem in action.

I've viewed the video (seems to not play on macOS by default, but worked fine in VLC.), and re-created a similar scenario at https://www.mediawiki.org/w/index.php?title=Project:Sandbox&oldid=4572177 with 28 references.

I was not able to reproduce the issue. I did:

  1. Select ref 10. Click Edit. Add " xxx". Apply changes.
  2. Repeat for ref 11.
  3. Repeat for ref 12.
  4. Repeat for ref 13.
  5. Repeat for ref 14.
  6. Repeat for ref 15.

For none of these did the "Edit" button require a second click, nor did I encounter other unexpected dialog openings or closings.

Tested on Firefox 88 (latest stable) on macOS.

Thanks for testing! My setup was Chrome on Ubuntu Linux 18.04.

Thanks. I can reproduce the issue today on Chrome (currently version 90). Editing ref 10, 11 and 12 is fine. Then number 13, the "Edit" click results in the page scroll shifting unexpectedly and no dialog indeed. On second try it works again indeed.

Nice bug catch!

Glad to hear it! This was a tough bug to notice. I kept thinking it was my fault for clicking imprecisely. :-)