Page MenuHomePhabricator
Create Task
Maniphest T252681

Do not add a title to an upload page if {{int:filedesc}} is blank
Closed, ResolvedPublic
Actions

Description

Special:Upload prepends "== {{int:filedesc}} ==" to file upload pages. If the filedesc message has been deliberately changed from its default value ("Summary" in English) to a blank value, then do not prepend any title at all.

Currently, if filedesc is blank, then the file upload page is prepended with "== ==".

Note, as per matthiasmullie's comment on T187302, it used to be possible to default to no title until his change of 6 Mar 2018.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Follow section headers by single newline instead of double newlineMr. Starfleet Commandmediawiki/coremaster+30 -31
Check if filedesc is empty and use newsectionheaderdefaultlevelMr. Starfleet Commandmediawiki/coremaster+30 -18
Customize query in gerrit

Related Objects

Event Timeline

Stelio created this task.May 13 2020, 3:02 PM
Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptMay 13 2020, 3:02 PM
Reedy added a project: MediaWiki-Uploading.May 13 2020, 3:02 PM
Mr._Starfleet_Command subscribed.Oct 28 2024, 11:53 PM
Mr._Starfleet_Command added a comment.EditedOct 28 2024, 11:59 PM

Also, the header should probably take its markup from MediaWiki:Newsectionheaderdefaultlevel instead of hard-coding it.

gerritbot added a comment.Feb 20 2025, 4:38 AM

Change #1121125 had a related patch set uploaded (by Mr. Starfleet Command; author: Mr. Starfleet Command):

[mediawiki/core@master] Check if filedesc is empty and use newsectionheaderdefaultlevel

https://gerrit.wikimedia.org/r/1121125

gerritbot added a project: Patch-For-Review.Feb 20 2025, 4:38 AM
SlyAceZeta subscribed.Feb 25 2025, 5:53 AM
Mr._Starfleet_Command changed the task status from Open to In Progress.Apr 17 2026, 4:32 AM
Mr._Starfleet_Command claimed this task.
PatchDemoBot added a comment.May 2 2026, 1:16 AM

Test wiki created on Patch demo by Mr. Starfleet Command using patch(es) linked to this task:
https://997c0a9f49.catalyst.wmcloud.org/w/

Mr._Starfleet_Command added a comment.May 2 2026, 1:46 AM
In T252681#11881001, @PatchDemoBot wrote:

Test wiki created on Patch demo by Mr. Starfleet Command using patch(es) linked to this task:
https://997c0a9f49.catalyst.wmcloud.org/w/

I was planning to test my patch with the above, but I can't upload files there because of T422996: Uploading files not working due to MediaWiki not being able to open a lock file. I'll try again once that bug is fixed. That said, my patch passed the automatic verification, and I'm pretty confident it does what it's supposed to. So, hopefully, this task will be resolved before too long. :)

KockaAdmiralac subscribed.May 2 2026, 1:52 AM
PatchDemoBot added a comment.May 14 2026, 5:25 PM

Test wiki on Patch demo by Mr. Starfleet Command using patch(es) linked to this task was deleted:

https://997c0a9f49.catalyst.wmcloud.org/w/

PatchDemoBot added a comment.May 14 2026, 5:30 PM

Test wiki created on Patch demo by Mr. Starfleet Command using patch(es) linked to this task:
https://e5b942930e.catalyst.wmcloud.org/w/

Mr._Starfleet_Command added a comment.May 14 2026, 5:57 PM

I've tested it, and it works: an image uploaded while the system message is non-empty (e.g. has its default content) gets the section header, while an image uploaded after the system message was blanked doesn't include a header at all. Yay! Now my patch just needs to get merged.

PatchDemoBot added a comment.May 14 2026, 11:53 PM

Test wiki on Patch demo by Mr. Starfleet Command using patch(es) linked to this task was deleted:

https://e5b942930e.catalyst.wmcloud.org/w/

gerritbot added a comment.Aug 26 2026, 4:19 AM

Change #1121125 merged by jenkins-bot:

[mediawiki/core@master] Check if filedesc is empty and use newsectionheaderdefaultlevel

https://gerrit.wikimedia.org/r/1121125

Maintenance_bot removed a project: Patch-For-Review.Aug 26 2026, 4:30 AM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.18; 2026-09-01).Aug 26 2026, 5:00 AM
Mr._Starfleet_Command closed this task as Resolved.Sep 3 2026, 6:21 PM
Umherirrender mentioned this in T437126: Special:Upload adding duplicate header.Sep 5 2026, 9:34 AM
gerritbot added a comment.Sat, Sep 5, 11:06 PM

Change #1328367 had a related patch set uploaded (by Mr. Starfleet Command; author: Mr. Starfleet Command):

[mediawiki/core@master] Follow section headers by single newline instead of double newline

https://gerrit.wikimedia.org/r/1328367

gerritbot added a project: Patch-For-Review.Sat, Sep 5, 11:06 PM
gerritbot added a comment.Mon, Sep 7, 1:36 AM

Change #1328367 merged by jenkins-bot:

[mediawiki/core@master] Follow section headers by single newline instead of double newline

https://gerrit.wikimedia.org/r/1328367

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.19; 2026-09-08); removed: MW-1.47-notes (1.47.0-wmf.18; 2026-09-01).Mon, Sep 7, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mon, Sep 7, 2:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits