In T252031 SpecialCheckUserGetLinksFromRow was deprecated and CheckUserGetLinksFromRow was added. StructuredDiscussions should be updated with the new hook.
Description
Details
- Due Date
- Jun 16 2020, 4:00 AM
Project | Branch | Lines +/- | Subject | |
---|---|---|---|---|
mediawiki/extensions/Flow | master | +33 -9 | Hooks: Add onCheckUserFormatRow for new hook from Special:Investigate |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Tchanders | T252695 Update Structured Discussions Implementation of SpecialCheckUserGetLinksFromRow to CheckUserGetLinksFromRow | |||
Resolved | Tchanders | T252031 Make TimelineRowFormatter::getLinks do the same checks as it is currently done in SpecialCheckUser | |||
Resolved | dmaza | T252089 Create a factory for the row formatter | |||
Resolved | dbarratt | T252485 Use TitleFormatter and SpecialPageFactory | |||
Resolved | dbarratt | T251465 Investigate how to handle SpecialCheckUserGetLinksFromRow on SpecialInvestigate |
Event Timeline
Change 598056 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/Flow@master] Hooks: Use CheckUserGetLinksFromRow instead of deprecated hook
Change 598056 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Hooks: Add onCheckUserFormatRow for new hook from Special:Investigate
I created a few Flow discussions and compared the output of the Timeline tab with the current CheckUser when "Get edits" is selected.
Information, links, etc. are the same, except the Timeline does not show Flow's autogenerated edit comment.
Special:Investigate:
Special:CheckUser:
I also compared the current CheckUser before and after this change by comparing to testwiki (in case we unintentionally changed anything).
I tested on my local docker (MediaWiki 1.35.0-alpha (fe3057c) 06:51, 5 June 2020; CheckUser 2.5 (b66ff7c) 06:52, 5 June 2020; Flow 1.2.0 (78b185c) 21:38, 4 June 2020).