Page MenuHomePhabricator
Create Task
Maniphest T252695

Update Structured Discussions Implementation of SpecialCheckUserGetLinksFromRow to CheckUserGetLinksFromRow
Closed, ResolvedPublic2 Estimated Story PointsJun 16 2020
Actions

Description

In T252031 SpecialCheckUserGetLinksFromRow was deprecated and CheckUserGetLinksFromRow was added. StructuredDiscussions should be updated with the new hook.

Details

Due Date
Jun 16 2020, 4:00 AM
ProjectBranchLines +/-Subject
mediawiki/extensions/Flowmaster+33 -9Hooks: Add onCheckUserFormatRow for new hook from Special:Investigate
Customize query in gerrit

Related Objects
Search...

Event Timeline

dbarratt created this task.May 13 2020, 4:51 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 13 2020, 4:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
dbarratt added a subtask: T252031: Make TimelineRowFormatter::getLinks do the same checks as it is currently done in SpecialCheckUser.May 13 2020, 4:53 PM
ARamirez_WMF set the point value for this task to 2.May 13 2020, 4:54 PM
dbarratt renamed this task from Update the Flow Implementation for the CheckUserLinks hook to Update the Flow Implementation of SpecialCheckUserGetLinksFromRow to CheckUserGetLinksFromRow.May 13 2020, 4:54 PM
dbarratt renamed this task from Update the Flow Implementation of SpecialCheckUserGetLinksFromRow to CheckUserGetLinksFromRow to Update Structured Discussions Implementation of SpecialCheckUserGetLinksFromRow to CheckUserGetLinksFromRow.May 13 2020, 4:57 PM
dbarratt updated the task description. (Show Details)
dbarratt claimed this task.May 13 2020, 6:07 PM
dbarratt moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
ARamirez_WMF removed dbarratt as the assignee of this task.May 13 2020, 6:55 PM
ARamirez_WMF edited projects, added Anti-Harassment; removed Anti-Harassment (The Letter Song).
ARamirez_WMF moved this task from Untriaged to Cards ready for development on the Anti-Harassment board.
Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.May 20 2020, 4:25 PM
Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
Niharika moved this task from In Progress 💪 to Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) on the Anti-Harassment (The Letter Song) board.
ARamirez_WMF set Due Date to Jun 2 2020, 4:00 AM.May 21 2020, 3:08 AM
ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".
dbarratt added a parent task: T251465: Investigate how to handle SpecialCheckUserGetLinksFromRow on SpecialInvestigate.May 21 2020, 3:41 PM
dbarratt removed a parent task: T251465: Investigate how to handle SpecialCheckUserGetLinksFromRow on SpecialInvestigate.
dbarratt added a subtask: T251465: Investigate how to handle SpecialCheckUserGetLinksFromRow on SpecialInvestigate.
Tchanders claimed this task.May 22 2020, 2:03 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
gerritbot added a comment.May 22 2020, 2:20 PM

Change 598056 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/Flow@master] Hooks: Use CheckUserGetLinksFromRow instead of deprecated hook

https://gerrit.wikimedia.org/r/598056

gerritbot added a project: Patch-For-Review.May 22 2020, 2:20 PM
Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.May 22 2020, 2:20 PM
Niharika closed subtask T252031: Make TimelineRowFormatter::getLinks do the same checks as it is currently done in SpecialCheckUser as Resolved.Jun 3 2020, 3:45 AM
gerritbot added a comment.Jun 3 2020, 4:36 PM

Change 598056 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Hooks: Add onCheckUserFormatRow for new hook from Special:Investigate

https://gerrit.wikimedia.org/r/598056

• aezell moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Jun 3 2020, 4:49 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 3 2020, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 3 2020, 5:10 PM
dom_walden moved this task from QA/Testing 🐞 to Done: Q4 (2019-20) on the Anti-Harassment (The Letter Song) board.EditedJun 8 2020, 4:30 PM
dom_walden added a subscriber: dom_walden.

I created a few Flow discussions and compared the output of the Timeline tab with the current CheckUser when "Get edits" is selected.

Information, links, etc. are the same, except the Timeline does not show Flow's autogenerated edit comment.

Special:Investigate:

flow_hook_cropped.png (76×1 px, 20 KB)

Special:CheckUser:
flow_hook_cu_comparison_cropped.png (129×871 px, 31 KB)

I also compared the current CheckUser before and after this change by comparing to testwiki (in case we unintentionally changed anything).

I tested on my local docker (MediaWiki 1.35.0-alpha (fe3057c) 06:51, 5 June 2020; CheckUser 2.5 (b66ff7c) 06:52, 5 June 2020; Flow 1.2.0 (78b185c) 21:38, 4 June 2020).

ARamirez_WMF changed Due Date from Jun 2 2020, 4:00 AM to Jun 17 2020, 4:00 AM.Jun 9 2020, 5:24 PM
ARamirez_WMF changed Due Date from Jun 17 2020, 4:00 AM to Jun 16 2020, 4:00 AM.Jun 9 2020, 8:28 PM
dbarratt closed subtask T251465: Investigate how to handle SpecialCheckUserGetLinksFromRow on SpecialInvestigate as Resolved.Jun 24 2020, 3:49 PM
Niharika closed this task as Resolved.Jul 31 2020, 9:43 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL