Regression: Menu consolidation has introduced overflow-wrap regression
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	May 13 2020, 9:10 PM

Description

DRYing up the menu T249372 has introduced a small regression of Portal links in the sidebar not being overflow-wrapped due to white-space: nowrap of verctor-menu li in place.

QA

Test URL: https://en.wikipedia.beta.wmflabs.org/?uselang=de
Check the menu items do not wrap.

QA Results - Beta

AC	Status	Details
1	✅	T252717#6142816

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	[dev] Remove `white-space` attribute from personal menu	mediawiki/skins/Vector	master	+0 -1

Customize query in gerrit

Related Objects

Mentioned Here: T249372: [Dev] DRY up the menu templating code

Event Timeline

Volker_E created this task.May 13 2020, 9:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2020, 9:10 PM

Hasn't ridden the train yet so good job catching!

Jdlrobson renamed this task from Menu consolidation has introduced overflow-wrap regression to Regression: Menu consolidation has introduced overflow-wrap regression.May 13 2020, 10:04 PM

Change 596309 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/Vector@master] [dev] Remove white-space attribute from personal menu

https://gerrit.wikimedia.org/r/596309

gerritbot added a project: Patch-For-Review.May 13 2020, 10:25 PM

Jdlrobson assigned this task to Edtadros.May 13 2020, 10:37 PM

Jdlrobson moved this task from Needs Analysis to Needs QA on the Web-Team-Backlog-Archived (Kanbanana-2019-20-Q4) board.

Jdlrobson updated the task description. (Show Details)

Change 596309 merged by jenkins-bot:
[mediawiki/skins/Vector@master] [dev] Remove white-space attribute from personal menu

https://gerrit.wikimedia.org/r/596309

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 13 2020, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 13 2020, 11:10 PM

As follow-up we want to be smarter with Menu.less separation. It now contains only personal menu styles, but on a generalized class .vector-menu.

Jdlrobson moved this task from Needs triage to Menus on the Vector (legacy skin) board.May 15 2020, 4:58 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: na

Test Artifact(s):

QA steps

Test URL: https://en.wikipedia.beta.wmflabs.org/?uselang=de
✅ AC1: Check the menu items do ~~not~~ wrap. (@Jdlrobson I assumed you meant that they do wrap)

Screen Shot 2020-05-16 at 11.09.12 PM.png (174×179 px, 13 KB)

Edtadros updated the task description. (Show Details)May 17 2020, 6:12 AM

Looks good, resolving!

	F31823669: Screen Shot 2020-05-16 at 11.09.12 PM.png
	May 17 2020, 6:10 AM

Regression: Menu consolidation has introduced overflow-wrap regressionClosed, ResolvedPublicActions