| Krinkle | |
| May 13 2020, 11:31 PM |
| F31816698: Screenshot 2020-05-14 at 01.21.43.png | |
| May 14 2020, 12:22 AM |
| F31816627: Screenshot 2020-05-14 at 00.27.20.png | |
| May 13 2020, 11:31 PM |
| F31816623: Screenshot 2020-05-14 at 00.29.21.png | |
| May 13 2020, 11:31 PM |
| F31816625: Screenshot 2020-05-14 at 00.29.17.png | |
| May 13 2020, 11:31 PM |
I can confirm this works as expected on group2/wmf.31 but is broken on wmf.32. Also it still works in all versions under MonoBook, which suggests it is a bug in Vector that was introduced in the new branch.
Issue on https://www.mediawiki.org/
| Vector (wmf.32) | MonoBook (wmf.31) | Vector (wmf.31) |
|---|---|---|
 |  |  |
Issue on https://wikitech.wikimedia.org/
| (wmf.32) |
|---|
 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | hashar | T249964 1.35.0-wmf.32 deployment blockers | ||
| Resolved | Edtadros | T252727 Regression: Plain text sidebar section stopped working in Vector |
Impact is fairly minimal, so assuming it gets fixed by next week it perhaps need not block the train (ref T249964).
The issue is spotted on wikitech.wikimedia.org as well. It is failing to fallback to plain text, but also wrongly double-escapes the label:
|
Change 596465 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@master] Allow plain text labels in side bar
Change 596465 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Allow plain text labels in side bar
Train blockers are unbreak now.
It seems it is all about deploying https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/596465/ to 1.35.0-wmf.32
Change 596503 had a related patch set uploaded (by Hashar; owner: Jdlrobson):
[mediawiki/skins/Vector@wmf/1.35.0-wmf.32] Allow plain text labels in side bar
Change 596503 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.35.0-wmf.32] Allow plain text labels in side bar
@matmarex helped with the deployment. The bug on mediawiki.org got worked around by creating a dummy page https://www.mediawiki.org/w/index.php?title=MediaWiki:MediaWiki.org . I have deleted it and that indeed confirmed the issue is fixed.
I added it as a blocker because I think it looks really silly, and because the sidebar is cached in funny ways, so it could be a while before the fix takes effect. (And we've actually just spent a good few minutes with @hashar trying to confirm whether it worked, because things were cached.)
Mentioned in SAL (#wikimedia-operations) [2020-05-14T20:15:25Z] <hashar@deploy1001> Synchronized php-1.35.0-wmf.32/skins/Vector/includes/VectorTemplate.php: Allow plain text labels in side bar - T252727 (duration: 01m 06s)
https://wikitech.wikimedia.org/ sidebar eventually got fixed a couple minutes or so after I have deployed.
Thank you @matmarex for all the assistance!