Page MenuHomePhabricator
Create Task
Maniphest T252735

CirrusSearch ext: Remove unused CirrusSearch const
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Class: CirrusSearch\Search\SearchQuery

Const: NEAR_MATCH and COMPLETION_SEARCH is never used

Details:

https://codesearch.wmflabs.org/deployed/?q=COMPLETION_SEARCH%7CNEAR_MATCH&i=nope&files=%5C.php%24&repos=

Expected result:

  • unused value with comment is deleted

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/CirrusSearchmaster+0 -12Removing NEAR_MATCH and COMPLETION_SEARCH unused constants.
Customize query in gerrit

Event Timeline

Art-Baltai created this task.May 14 2020, 1:33 AM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptMay 14 2020, 1:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Art-Baltai removed a project: Discovery-Search.May 14 2020, 1:33 AM
Art-Baltai set the point value for this task to 1.
Helga_sf reassigned this task from Art-Baltai to Peter.ovchyn.Jun 23 2020, 2:54 PM
Helga_sf triaged this task as Medium priority.Jul 1 2020, 3:23 PM
Helga_sf moved this task from Backlog to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.Jul 6 2020, 1:55 PM
Helga_sf reassigned this task from Peter.ovchyn to Art.tsymbar.Jul 7 2020, 12:22 PM
Helga_sf edited subscribers, added: Peter.ovchyn; removed: Art-Baltai.
Helga_sf moved this task from Current sprint Backlog to Backlog on the Platform Team Workboards (S&F Workboard) board.Aug 25 2020, 12:04 PM
Helga_sf moved this task from Backlog to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.Aug 27 2020, 11:47 AM
Art.tsymbar moved this task from Current sprint Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Sep 2 2020, 12:02 PM
gerritbot added a comment.Sep 2 2020, 12:26 PM

Change 623785 had a related patch set uploaded (by Art.tsymbar; owner: arttsymbar):
[mediawiki/extensions/CirrusSearch@master] Removing NEAR_MATCH and COMPLETION_SEARCH unused constants.

https://gerrit.wikimedia.org/r/623785

gerritbot added a project: Patch-For-Review.Sep 2 2020, 12:26 PM
Art.tsymbar moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Sep 2 2020, 12:27 PM
gerritbot added a comment.Sep 3 2020, 8:55 AM

Change 623785 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Removing NEAR_MATCH and COMPLETION_SEARCH unused constants.

https://gerrit.wikimedia.org/r/623785

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 3 2020, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 3 2020, 9:11 AM
Art.tsymbar moved this task from In Progress/In Review to PM Sign Off on the Platform Team Workboards (S&F Workboard) board.Sep 3 2020, 10:42 AM
Reedy closed this task as Resolved.Oct 25 2020, 8:29 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL