Page MenuHomePhabricator

Black theme: add ability to adjust font brightness
Closed, DeclinedPublic

Description

I love dark themes - for me this is much easier for eyes to read. Also a plus on a mobile device - because black theme save the battery. But for me current font color is too white. I want to make it a little darker, also I want to have an ability to try a kind of orange font color - like Night Shift on macOS.

Event Timeline

Thanks @vitaly-zdanevich - we will have a chat about this.

cc @schoenbaechler re: your comments on the white-on-black font being too bright.

thx for the cc @Charlotte and @vitaly-zdanevich for creating the task. made some first explorations over here: T250202#6133137.

Oops, I accidentaly moved this task to done... And I cannot drag it back...

@Sharvaniharan - Can you tell us why this is blocked/what this is waiting for?

@Charlotte i parked it in blocked for further steps and wanted to discuss this on our prioritization on Wednesday.

There are 3 major hurdles here, which I wanted to discuss with you and @schoenbaechler :

  1. This would need us to maintain 6 different style sheets and would imply testing in the future for all style combinations.
  2. We would need a platform-specific [unless iOS wants to do this too] hook on mobile-html service, to change text color per selection, on articles.
  3. Minor addition would be, having to remember the text color preference for dark modes while matching to system theme.

and even after all this, it wouldn't be a slider kind of wide-range selection like the text size, as expected by this ticket. It would only be the 2-3 brightness levels.
A much simpler solution would be for us to meet mid-way. Probably have a less bright text color defined be default for our dark and black modes, and if the users want any more adjustment with brightness, they can achieve it by adjusting system brightness.
^ cc @Dbrant @cooltey

Thx @Sharvaniharan for investigating on this.

A much simpler solution would be for us to meet mid-way. Probably have a less bright text color defined be default for our dark and black modes, and if the users want any more adjustment with brightness, they can achieve it by adjusting system brightness.

This is exactly the way to go. I think this is not about letting users adjust font brightness it’s about getting dark themes right — which is something I’d like to look into at a later point in time. I see that @Dbrant already moved it to UX backlog already, which I think is the way to go for now.

In T252838#6375293, @schoenbaechler wrote:

Thx @Sharvaniharan for investigating on this.

A much simpler solution would be for us to meet mid-way. Probably have a less bright text color defined be default for our dark and black modes, and if the users want any more adjustment with brightness, they can achieve it by adjusting system brightness.

This is exactly the way to go. I think this is not about letting users adjust font brightness it’s about getting dark themes right — which is something I’d like to look into at a later point in time. I see that @Dbrant already moved it to UX backlog already, which I think is the way to go for now.

Precisely. This is a lower priority than the other things we're doing (the users can meanwhile adjust their system brightness) so I'm happy to keep it in the backlog and optimise the dark themes as and when we can. I am definitely not happy to maintain 6 stylesheets and make mobile-html changes.

Charlotte lowered the priority of this task from Medium to Low.Aug 11 2020, 10:02 AM

I'm afraid this won't be in our plans. Text brightness can be adjusted using the system Brightness controls, and Android 10+ has the Night Light feature that shifts colors towards night-friendly warm tones.