Page MenuHomePhabricator

Wikivoyage deprecation warnings relating to unsupported SidebarBeforeOutput usage
Closed, ResolvedPublic

Description

Use of `content` field in portal docents must be array.Previously it could be a string but this is no longer supported. was deprecated in MediaWiki 1.35.0. [Called from VectorTemplate::getSkinData in /srv/mediawiki/php-1.35.0-wmf.32/skins/Vector/includes/VectorTemplate.php at line 223]

This relates to a recent change in Vector
About 628 errors in the last 3 days

Looking at the errors i believe this is originating from the Insider extension because that does seem to be adding HTML links instead of data arrays.
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Insider/+/master/includes/InsiderHooks.php#118

https://logstash.wikimedia.org/goto/21b810acf89c9d8dc6bd5f9fa8cd8422

To fix, this should be updated to return an array liek so:

 [
  'text'=> $userTitle->getText(),
  "href" => $userTitle->getLocalUrl(),
"class" =>'interwiki-insider',
]

Event Timeline

Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptThu, May 14, 10:42 PM
Jdlrobson triaged this task as High priority.Thu, May 14, 10:44 PM

Not sure how important this extension is to Wikivoyage, but given this will break soon should be considered high priority.

Jdlrobson renamed this task from Wikivoyage deprecation warnings to Wikivoyage deprecation warnings relating to unsupported SidebarBeforeOutput usage.Thu, May 14, 10:48 PM
Jdlrobson added a project: patch-welcome.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.
Krinkle added a subscriber: Krinkle.EditedTue, May 19, 10:31 PM

If not fixed soon, consider reversing the deprecation for now. Code in prod should not have been deprecated (ref T252923).

If the code was tested, Jenkins would have prevented the merging of the deprecating commit in Vector.

Thanks for the bump @Krinkle I had a patch prepared but I guess my git review was not setup. Pushing now.

Change 597357 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Insider@master] Insider extension should use SidebarBeforeOutput with correct format

https://gerrit.wikimedia.org/r/597357

Change 597357 merged by jenkins-bot:
[mediawiki/extensions/Insider@master] Use SidebarBeforeOutput hook with correct format

https://gerrit.wikimedia.org/r/597357

Change 597368 had a related patch set uploaded (by Jforrester; owner: Jdlrobson):
[mediawiki/extensions/Insider@wmf/1.35.0-wmf.32] Use SidebarBeforeOutput hook with correct format

https://gerrit.wikimedia.org/r/597368

Change 597368 merged by jenkins-bot:
[mediawiki/extensions/Insider@wmf/1.35.0-wmf.32] Use SidebarBeforeOutput hook with correct format

https://gerrit.wikimedia.org/r/597368

Mentioned in SAL (#wikimedia-operations) [2020-05-19T23:57:40Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.32/extensions/Insider/includes/InsiderHooks.php: T252846 Use SidebarBeforeOutput hook with correct format (duration: 01m 06s)

Jdforrester-WMF closed this task as Resolved.Tue, May 19, 11:58 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Deployed, now working again.