Page MenuHomePhabricator

Page forms failed on "save and continue" in form with a lot of Visual Editors
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  • Create form with a lot of Viusual editors (using VEForall) - at least 32
  • Try to save and continue

Actual Results:

  • Page form would send 30 or more ajax calls for each VEditor
  • The ajax call for save and continue would fail, probably because SCRF token expired

Expected Results:

  • page form would send ajax calls just for editors with content modified by user

Event Timeline

Change 596608 had a related patch set uploaded (by Aklapper; owner: Anysite):
[mediawiki/extensions/VEForAll@master] Prevent PageForms saving untouched VEditors when submitting

https://gerrit.wikimedia.org/r/596608

Change 596608 merged by jenkins-bot:

[mediawiki/extensions/VEForAll@master] Prevent PageForms saving untouched VEditors when submitting

https://gerrit.wikimedia.org/r/596608

Yaron_Koren claimed this task.
Yaron_Koren added a subscriber: Yaron_Koren.

@Anysite - thank you for the patch, and sorry for the extremely long delay on it! Hopefully this merge is better late than never.