The block informing about related Gerrit changesets on Maniphest tasks shows the changeset state with an icon. "Merged" used to be a green tick mark, but has changed recently to a grey git branching icon, which is not particularly helpful. (I first thought it's maybe an attempt to differentiate between merged and deployed to production, but that doesn't seem to be the case.) Please restore the old icon.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • mmodell | T253090 Virtual Offsite: Phabricator hacking session | |||
| Declined | None | T252866 Make "merged" icon in Maniphest's Gerrit info block to be a green tick mark instead of a grey git branching icon |
Event Timeline
Comment Actions
On a side note, the unresolved comment count (is that new, or have I just not payed attention before?) is pretty cool. Thanks for working on that!
Comment Actions
This requires a patch in the file src/customfields/GerritPatchesCustomField.php of the repo https://gitlab.wikimedia.org/repos/phabricator/extensions :
$icon = 'fa-code-fork black' should become 'fa-check-circle-o green' probably.
FYI, https://phabricator.wikimedia.org/uiexample/view/PHUIIconExample/ lists all icons.
Comment Actions
Thinking more about this, I'm not convinced - a green tick mark might also mean "ready to go" but not "merged"?