Warning flood: "Use of SkinTemplateToolboxEnd hook was deprecated "
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Krinkle
	May 15 2020, 6:42 PM

Description

Error message

Use of SkinTemplateToolboxEnd hook (used in ShortUrlHooks::addToolboxLink) was deprecated in MediaWiki 1.35. [Called from MediaWiki\HookContainer\HookContainer::run in /srv/mediawiki/php-1.35.0-wmf.32/includes/HookContainer/HookContainer.php at line 132]

Impact

7,000+ warnings logged per hour to Logstash. And that's only with group1 traffic.

Notes

Most likely caused by https://gerrit.wikimedia.org/r/587536, which added a Hooks::run() call in Vector code, for a hook owned by core. It also called it with hard-deprecation (when the core hook isn't), leading to some confusion during the investigation into this.

The hook callsite needs to be un-deprecated, or the caller(s) migrated/removed.

https://logstash.wikimedia.org/app/kibana#/dashboard/mediawiki-deprecated

Screenshot 2020-05-15 at 19.42.39.png (678×2 px, 181 KB)

Details

Project	Branch	Lines +/-	Subject
mediawiki/skins/Vector	wmf/1.35.0-wmf.32	+1 -1	VectorTemplate: SkinTemplateToolboxEnd hook isn't deprecated
mediawiki/skins/Vector	master	+1 -1	VectorTemplate: SkinTemplateToolboxEnd hook isn't deprecated
mediawiki/skins/Vector	master	+2 -2	Temporarily Undeprecate SkinTemplateToolboxEnd

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Jdrewniak	T249372 [Dev] DRY up the menu templating code
Resolved	PRODUCTION ERROR	DannyS712	T252906 Warning flood: "Use of SkinTemplateToolboxEnd hook was deprecated "
Resolved		None	T252917 Drop support for SkinTemplateToolboxEnd in Vector, with suitable replacement

Event Timeline

Krinkle triaged this task as Unbreak Now! priority.May 15 2020, 6:42 PM

Krinkle created this task.

Krinkle added a parent task: T249964: 1.35.0-wmf.32 deployment blockers.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 15 2020, 6:42 PM

Change 596748 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/skins/Vector@master] VectorTemplate: SkinTemplateToolboxEnd hook isn't deprecated

https://gerrit.wikimedia.org/r/596748

gerritbot added a project: Patch-For-Review.May 15 2020, 8:56 PM

DannyS712 added a subscriber: DannyS712.May 15 2020, 8:58 PM

Change 596757 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@master] Temporarily Undeprecate SkinTemplateToolboxEnd

https://gerrit.wikimedia.org/r/596757

Jdlrobson moved this task from Needs Analysis to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q4) board.May 15 2020, 9:22 PM

Change 596757 abandoned by Jdlrobson:
Temporarily Undeprecate SkinTemplateToolboxEnd

Reason:
done in https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/ /596760/1

https://gerrit.wikimedia.org/r/596757

Jdlrobson mentioned this in T252917: Drop support for SkinTemplateToolboxEnd in Vector, with suitable replacement.May 15 2020, 9:24 PM

Change 596748 merged by jenkins-bot:
[mediawiki/skins/Vector@master] VectorTemplate: SkinTemplateToolboxEnd hook isn't deprecated

https://gerrit.wikimedia.org/r/596748

Change 596768 had a related patch set uploaded (by Krinkle; owner: DannyS712):
[mediawiki/skins/Vector@wmf/1.35.0-wmf.32] VectorTemplate: SkinTemplateToolboxEnd hook isn't deprecated

https://gerrit.wikimedia.org/r/596768

DannyS712 claimed this task.May 15 2020, 9:52 PM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptMay 15 2020, 9:52 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 15 2020, 10:00 PM

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.May 15 2020, 10:09 PM

Krinkle mentioned this in T252923: Ensure flood of hard-deprecations are caught during (train) deployments.May 15 2020, 10:47 PM

Change 596768 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.35.0-wmf.32] VectorTemplate: SkinTemplateToolboxEnd hook isn't deprecated

https://gerrit.wikimedia.org/r/596768

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.32; 2020-05-12); removed MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 18 2020, 1:00 PM

Mentioned in SAL (#wikimedia-operations) [2020-05-18T13:00:48Z] <hashar@deploy1001> Synchronized php-1.35.0-wmf.32/skins/Vector/includes/VectorTemplate.php: VectorTemplate: SkinTemplateToolboxEnd hook isn't deprecated - T252906 (duration: 01m 07s)

The deprecation logging is gone as part of the deployment, hence this is no more a train blocker.

I am leaving this one open as to why Vector uses the mediawiki/core hook SkinTemplateToolboxEnd, but maybe it is simply being migrated to the skins.

Maintenance_bot removed a project: Patch-For-Review.May 18 2020, 1:10 PM

In T252906#6144628, @hashar wrote:

The deprecation logging is gone as part of the deployment, hence this is no more a train blocker.

I am leaving this one open as to why Vector uses the mediawiki/core hook SkinTemplateToolboxEnd, but maybe it is simply being migrated to the skins.

Not familiar with the use history, leaving for someone else

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q4) board.May 18 2020, 5:24 PM