Page MenuHomePhabricator

Warning flood: "Use of SkinTemplateToolboxEnd hook was deprecated "
Closed, ResolvedPublic

Description

Error message
Use of SkinTemplateToolboxEnd hook (used in ShortUrlHooks::addToolboxLink) was deprecated in MediaWiki 1.35. [Called from MediaWiki\HookContainer\HookContainer::run in /srv/mediawiki/php-1.35.0-wmf.32/includes/HookContainer/HookContainer.php at line 132]
Impact

7,000+ warnings logged per hour to Logstash. And that's only with group1 traffic.

Notes

Most likely caused by https://gerrit.wikimedia.org/r/587536, which added a Hooks::run() call in Vector code, for a hook owned by core. It also called it with hard-deprecation (when the core hook isn't), leading to some confusion during the investigation into this.

The hook callsite needs to be un-deprecated, or the caller(s) migrated/removed.

https://logstash.wikimedia.org/app/kibana#/dashboard/mediawiki-deprecated

Event Timeline

Krinkle triaged this task as Unbreak Now! priority.Fri, May 15, 6:42 PM
Krinkle created this task.
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptFri, May 15, 6:42 PM

Change 596748 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/skins/Vector@master] VectorTemplate: SkinTemplateToolboxEnd hook isn't deprecated

https://gerrit.wikimedia.org/r/596748

Change 596757 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@master] Temporarily Undeprecate SkinTemplateToolboxEnd

https://gerrit.wikimedia.org/r/596757

Change 596757 abandoned by Jdlrobson:
Temporarily Undeprecate SkinTemplateToolboxEnd

Reason:
done in https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/ /596760/1

https://gerrit.wikimedia.org/r/596757

Change 596748 merged by jenkins-bot:
[mediawiki/skins/Vector@master] VectorTemplate: SkinTemplateToolboxEnd hook isn't deprecated

https://gerrit.wikimedia.org/r/596748

Change 596768 had a related patch set uploaded (by Krinkle; owner: DannyS712):
[mediawiki/skins/Vector@wmf/1.35.0-wmf.32] VectorTemplate: SkinTemplateToolboxEnd hook isn't deprecated

https://gerrit.wikimedia.org/r/596768

Restricted Application added a project: User-DannyS712. · View Herald TranscriptFri, May 15, 9:52 PM

Change 596768 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.35.0-wmf.32] VectorTemplate: SkinTemplateToolboxEnd hook isn't deprecated

https://gerrit.wikimedia.org/r/596768

Mentioned in SAL (#wikimedia-operations) [2020-05-18T13:00:48Z] <hashar@deploy1001> Synchronized php-1.35.0-wmf.32/skins/Vector/includes/VectorTemplate.php: VectorTemplate: SkinTemplateToolboxEnd hook isn't deprecated - T252906 (duration: 01m 07s)

hashar lowered the priority of this task from Unbreak Now! to High.Mon, May 18, 1:06 PM
hashar added a subscriber: hashar.

The deprecation logging is gone as part of the deployment, hence this is no more a train blocker.

I am leaving this one open as to why Vector uses the mediawiki/core hook SkinTemplateToolboxEnd, but maybe it is simply being migrated to the skins.

DannyS712 removed DannyS712 as the assignee of this task.Mon, May 18, 4:36 PM

The deprecation logging is gone as part of the deployment, hence this is no more a train blocker.

I am leaving this one open as to why Vector uses the mediawiki/core hook SkinTemplateToolboxEnd, but maybe it is simply being migrated to the skins.

Not familiar with the use history, leaving for someone else

Jdlrobson closed this task as Resolved.Tue, May 19, 5:05 PM
Jdlrobson claimed this task.
Jdlrobson added a subscriber: Jdlrobson.

follow up work captured in T252917