Page MenuHomePhabricator

Inconsistent gallery image when tapping on lead image
Closed, ResolvedPublicBUG REPORT

Description

How many times were you able to reproduce it?

Every time

Steps to reproduce

  1. Go to Basic reproduction number in EN Wikipedia
  2. Notice header image, tap it.

Expected results

Header image and gallery should match

Actual results

Gallery image shows a different image.

Screenshots

image1.png (320×147 px, 90 KB)

image0.png (320×147 px, 97 KB)

Environments observed

App version: 6.5.1
OS versions: 13.4.1
Device model: iPhone 7
Device language: EN

Affected articles?

  • Basic reproduction number
Edit:

This is currently reproducible using this EN page: https://en.wikipedia.org/wiki/Pago_Pago

Event Timeline

LGoto triaged this task as Medium priority.May 18 2020, 6:45 PM
LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

Also happening on Academy Awards article - Academy Awards article uses Joaquin Phoenix pic as the article header photo. When you tap it, you get the Oscar statue picture.

Also happening on "History of the United Arab Emirates"

Also happening on EN "Amazon rainforest".

LGoto lowered the priority of this task from Medium to Low.Sep 22 2020, 8:20 PM

This work (https://phabricator.wikimedia.org/T269312) adds a leadImage property to the API response for media list items. This property indicates whether a particular media item represents the lead image for the page (that is, it matches the rest_v1/page/mobile-html endpoint's mw:leadImage property). I've confirmed on the Staging scheme (against the mobileapps labs instance) with a few test articles that leadImage property is being returned in the responses and so far they appear to be properly indicating the lead image of the article.

When that work is deployed to production, we should update the client to check this flag. That will resolve most (but not all) cases of tapping the lead image in the article view resulting in seeing the incorrect image in the gallery. If we don't update our client immediately when the change is deployed, that's ok – our media-list endpoint decoding will still function as if nothing changed because we just aren't specifying a coding key for the new leadImage property. I've prototyped the basic idea of the fix required here, but we should properly explore our client side fix once the PI patch is deployed.

Dmantena renamed this task from Inconsistent header & gallery image for 'Basic reproduction number' to Inconsistent gallery image when tapping on lead image.Dec 8 2021, 6:30 PM
Dmantena added subscribers: cmadeo, LGoto, ABorbaWMF.

Another report of this from Znuny:
https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=12020581

Sehr geehrte Damen und Herren,
wenn ich auf ein Bild drücke, wird nicht das gedrückte Bild im Vollbild angezeigt, sondern das erste Bild auf dieser Wikipedia-Seite im Vollbild gezeigt.

Here's a related report - https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=12041079#14591157

It seems like for non-EN articles, tapping an image later in the article always displays the first image in the gallery. I also see this in our latest main branch (tested the Cat article in FR and DE Wikipedia). Can you take a quick look at this just to confirm if it's the same problem or if we should spin up a new task? @Dmantena

Hello there, I just made an account to point out that I wholeheartedly disagree with this bug being prioritised as „low“.

It is the most annoying thing for me when using the app, it happens not some time, but every single time when clicking an image. It actually has stopped me from using the app, it made me prefer the browser version so I can actually click on images.

And it has been around for as long as I can remember. This should be of priority „high“ or more.

Edit: I‘m talking about the fact that clicking any image always opens a gallery with the article‘s first one, a bug that has been marked as a duplicate of this one.

@Flyseb: Hi and welcome. Please see https://www.mediawiki.org/wiki/Bug_management/Development_prioritization why "priotities" differ - thanks.
(Also, there's a patch awaiting review in T252920#7557340)

It seems like for non-EN articles, tapping an image later in the article always displays the first image in the gallery. I also see this in our latest main branch (tested the Cat article in FR and DE Wikipedia). Can you take a quick look at this just to confirm if it's the same problem or if we should spin up a new task? @Dmantena

@Tsevener I can also reproduce this - fortunately, it does not seem related to our work here. I made a new ticket for it with my notes: https://phabricator.wikimedia.org/T298566

JMinor claimed this task.