Update PCS defaultOutputModeForPOSTResponse
Closed, ResolvedPublic
Actions

Description

After RESTBase (patch will be linked after it is up) has deployed their editPreview patch, update PCS's mRequestUtil.defaultOutputModeForPOSTResponse (in mobile-request-util.js to MobileHTML.OutputMode.contentAndReferences.

Also need to update the description and headers in spec/transform/html-to-mobile-html.yaml.

This is blocked by a RESTBase patch, which is in turn blocked by this PCS patch[1] being merged and deployed.

[1]https://gerrit.wikimedia.org/r/c/mediawiki/services/mobileapps/+/596284

Details

	Subject	Repo	Branch	Lines +/-
	Update documentation for html/to/mobile-html endpoint	mediawiki/services/mobileapps	master	+16 -5
	Update default output mode	mediawiki/services/mobileapps	master	+10 -4

Customize query in gerrit

Related Objects

Mentioned In: T252689: Bug: `contentAndReferences` cannot be succesfully used as `output-mode`

Event Timeline

• MattCleinman created this task.May 15 2020, 9:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2020, 9:55 PM

• MattCleinman updated the task description. (Show Details)May 15 2020, 9:57 PM

• MattCleinman mentioned this in T252689: Bug: `contentAndReferences` cannot be succesfully used as `output-mode`.May 20 2020, 12:02 AM

LGoto triaged this task as Low priority.May 21 2020, 7:26 PM

LGoto added a project: Wikipedia-iOS-App-Backlog.

LGoto moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.

LGoto edited projects, added iOS-app-v6.7-Bonefish-On-A-Bus; removed iOS-app-v6.6.1-Penguin-On-A-Luge.

Ping Platform Engineering for review of https://github.com/wikimedia/restbase/pull/1261.

• Pchelolo edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Engineering.Jun 11 2020, 7:53 PM

Change 605321 had a related patch set uploaded (by Matt Cleinman; owner: Matt Cleinman):
[mediawiki/services/mobileapps@master] Update default output mode

https://gerrit.wikimedia.org/r/605321

gerritbot added a project: Patch-For-Review.Jun 12 2020, 9:29 PM

• MattCleinman renamed this task from [HOLD for RESTbase] Update PCS defaultOutputModeForPOSTResponse to Update PCS defaultOutputModeForPOSTResponse.Jun 12 2020, 9:30 PM

• MattCleinman moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v6.7-Bonefish-On-A-Bus board.

• MattCleinman edited projects, added iOS-app-v6.6.1-Penguin-On-A-Luge; removed iOS-app-v6.7-Bonefish-On-A-Bus.Jun 13 2020, 12:04 AM

• MattCleinman moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v6.6.1-Penguin-On-A-Luge board.

New decision: We're going to leave the default as EditPreview.

Next steps:

Close out PCS ticket that changes default
Update RestBase documentation regarding default
Confirm there is no PCS change that is needed
Update native iOS PR with discussion: https://github.com/wikimedia/wikipedia-ios/pull/3609

Change 605321 abandoned by Matt Cleinman:
Update default output mode

Reason:
We decided to keep the default as editPreview. Updating documentation in another patch.

https://gerrit.wikimedia.org/r/605321

Change 606529 had a related patch set uploaded (by Matt Cleinman; owner: Matt Cleinman):
[mediawiki/services/mobileapps@master] Update documentation for html/to/mobile-html endpoint

https://gerrit.wikimedia.org/r/606529

Documentation for restbase done in this PR: https://github.com/wikimedia/restbase/pull/1265

Change 606529 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Update documentation for html/to/mobile-html endpoint

https://gerrit.wikimedia.org/r/606529

LGoto removed a project: iOS-app-v6.6.1-Penguin-On-A-Luge.Jun 23 2020, 6:38 PM

• Pchelolo moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (External Code Reviews) board.Jun 25 2020, 3:22 AM

• MattCleinman closed this task as Resolved.Oct 27 2020, 8:46 PM