Page MenuHomePhabricator

Pre-deployment QA: Reply tool v2.0 instrumentation
Closed, ResolvedPublic

Description

T252924 added new fields to the the VisualEditorFeatureUse schema [1][2].

This task is about ensuring these newly added events and fields are firing correctly on beta.

Events and fields to check

See: Replying QC Template : Instrumentation QA and data checks

Testing details

Open questions

  • What actions should be checked?
    • See "Testing details" above.
  • What events should said "actions" emit?
    • See "Testing details" above.
  • What editing interfaces do these "actions" and "events" need to be tested on?
    • This task is limited to ensuring the fields and events that have been added to VisualEditorFeatureUse are firing correctly in the Reply tool. Testing of the other editing interfaces (VE, MobileFrontend, WikiEditor) will happen in T252925.

Done

  • All "events" and "fields" specified in the instrumentation sheet have been verified as firing ("yes" / "no") and being logged ("yes" / "no")

  1. https://www.mediawiki.org/wiki/VisualEditor/FeatureUse_data_dictionary
  2. https://meta.wikimedia.org/wiki/Schema:VisualEditorFeatureUse

Event Timeline

Update
Notes from the conversation @Ryasmeen and I had today...

  • What is the best way to represent the QA work needed to test these "actions" and "events" on different editing interfaces?

Each editing interface will need its own QA ticket.

The above is now represented in the task description.

Next steps

  • @ppelberg to create tickets for each editing interface that needs to be QA'd.
ppelberg updated the task description. (Show Details)

Task description update
Resolving first two "Open questions" and linking to to the QA action and event key: Replying QC Template : Instrumentation QA and data checks.

ppelberg updated the task description. (Show Details)
ppelberg added a subscriber: Ryasmeen.

@Mayakp.wiki: I'm assigning this task over to you to populate the events and actions in the Replying QC Template : Instrumentation QA and data checks; once this is complete, can you please assign this task over to @Ryasmeen so she knows when to start testing?

Update
Updated the task description to include the answer to the last remaining "Open question":

  • What editing interfaces do these "actions" and "events" need to be tested on?
    • This task is limited to ensuring the fields and events that have been added to VisualEditorFeatureUse are firing correctly in the Reply tool. Testing of the other editing interfaces (VE, MobileFrontend, WikiEditor) will happen in T252925.

Events and Fields to be tested for Replying V2.0 Instrumentation have been added to this tab of the QA document.
Also updated description of this task with the link.

Events and Fields to be tested for Replying V2.0 Instrumentation have been added to this tab of the QA document.
Also updated description of this task with the link.

Excellent. Thank you, Maya. Assigning this over to @Ryasmeen.

T254366 adds an icon ("👤" for now) that will launch mwUsernameCompletion feature.

As such, @Mayakp.wiki are you able to update to the Replying QC template with the following? [i]

  • "editor_interface": "visualeditor"
  • "schema": "VisualEditorFeatureUse"
  • "feature": "mwUsernameCompletion"
  • "action": "window-open-from-tool"

...@DLynch please let me know if any attributes of the above look incorrect to you.


i. I'm capable of updating the sheet as well; tho, I don't have edit access, thus why I thought to ask here.

This seems like a new development! I have added it to the Instrumentation spec as well as updated the Replying QC document .
Thanks for letting me know, I have also changed document permissions for editing.

This seems like a new development! I have added it to the Instrumentation spec as well as updated the Replying QC document .

It is. I didn't mean to suggest this was an oversight on yours or anyone else's. By the way, that "New" image on the sheet is great. Eye-catching!

Thanks for letting me know, I have also changed document permissions for editing.

100% and thank you, Maya.

I checked all the events, everything is getting logged as specified on the QC template. However I noticed the following two events are not listed in that spreadsheet:

  1. Type text into the input > Click the "Link" i.e. "🔗" icon to add a hyperlink on selected text > type into the search field within the "Wikipedia" tab

The event that's getting fired in this case has action: "search-pages-input".

  1. Type text into the input > Format the text in some way > Click "remove formatting" from the "A" menu.

The event fired has: feature: "allAnnotations", action: "clear-all".

@DLynch: Could you confirm if they are correct?

@ppelberg: I have updated the QC template to include these two scenarios and assuming they are working as expected, I am moving it to the PM column.