Page MenuHomePhabricator
Create Task
Maniphest T252978

Wikimedia deployed extensions need uses of global $wgOut removed
Open, MediumPublic
Actions

Description

Code search:

  • 3D
  • CirrusSearch
  • Collection
  • ConfirmEdit
  • FlaggedRevs
  • Flow
  • GuidedTour
  • LiquidThreads
  • Newsletter
  • ProofreadPage
  • TimedMediaHandler
  • VipsScaler
  • Wikibase
  • WikimediaEvents
  • WikimediaIncubator

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.May 18 2020, 2:13 AM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.
gerritbot added a comment.May 18 2020, 2:15 AM

Change 596902 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/VipsScaler@master] SpecialVipsTest: Remove use of global $wgOut

https://gerrit.wikimedia.org/r/596902

gerritbot added a project: Patch-For-Review.May 18 2020, 2:15 AM
DannyS712 moved this task from Next to Projects on the User-DannyS712 board.May 18 2020, 2:17 AM
DannyS712 triaged this task as Medium priority.May 18 2020, 5:31 AM
gerritbot added a comment.Jun 11 2020, 7:10 AM

Change 562006 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TimedMediaHandler@master] Remove some uses of global $wgUser and global $wgOut

https://gerrit.wikimedia.org/r/562006

DannyS712 added a project: Platform Team Workboards (External Code Reviews).Jul 8 2020, 8:53 AM
gerritbot added a comment.Aug 29 2020, 10:47 AM

Change 596902 merged by jenkins-bot:
[mediawiki/extensions/VipsScaler@master] SpecialVipsTest: Remove use of global $wgOut

https://gerrit.wikimedia.org/r/596902

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Aug 29 2020, 11:00 AM
gerritbot added a comment.Sep 3 2020, 7:34 PM

Change 562006 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Remove some uses of global $wgUser and global $wgOut

https://gerrit.wikimedia.org/r/562006

Maintenance_bot removed a project: Patch-For-Review.Sep 3 2020, 8:11 PM
gerritbot added a comment.Sep 3 2020, 8:45 PM

Change 623905 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaIncubator@master] Remove uses of global $wgOut

https://gerrit.wikimedia.org/r/623905

gerritbot added a project: Patch-For-Review.Sep 3 2020, 8:45 PM
gerritbot added a comment.Sep 4 2020, 2:22 PM

Change 623905 merged by jenkins-bot:
[mediawiki/extensions/WikimediaIncubator@master] Remove uses of global $wgOut

https://gerrit.wikimedia.org/r/623905

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2020, 3:10 PM
gerritbot added a comment.Sep 10 2020, 9:28 PM

Change 626435 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CodeReview@master] Reduce direct references to $wgOut

https://gerrit.wikimedia.org/r/626435

gerritbot added a project: Patch-For-Review.Sep 10 2020, 9:28 PM
gerritbot added a comment.Sep 10 2020, 10:35 PM

Change 626435 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Reduce direct references to $wgOut

https://gerrit.wikimedia.org/r/626435

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.9; 2020-09-15); removed MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 10 2020, 11:01 PM
taavi updated the task description. (Show Details)Dec 29 2020, 4:25 PM
• AMooney removed a project: Platform Team Workboards (External Code Reviews).Apr 14 2021, 7:49 PM
DannyS712 updated the task description. (Show Details)Jul 10 2021, 1:56 AM
DannyS712 updated the task description. (Show Details)
DannyS712 updated the task description. (Show Details)
HouseBlaster moved this task from Unsorted to Needs removal on the Technical-Debt board.Dec 3 2022, 1:20 AM
gerritbot added a comment.May 15 2023, 7:51 PM

Change 919884 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/3D@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919884

gerritbot added a comment.May 15 2023, 8:08 PM

Change 919889 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GuidedTour@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919889

gerritbot added a comment.May 15 2023, 8:10 PM

Change 919890 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CirrusSearch@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919890

gerritbot added a comment.May 15 2023, 8:12 PM

Change 919891 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikimediaEvents@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919891

gerritbot added a comment.May 15 2023, 8:14 PM

Change 919892 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Newsletter@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919892

gerritbot added a comment.May 15 2023, 8:16 PM

Change 919893 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ProofreadPage@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919893

gerritbot added a comment.May 15 2023, 8:23 PM

Change 919899 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FlaggedRevs@master] Replace $wgOut with Article::getContext()

https://gerrit.wikimedia.org/r/919899

gerritbot added a comment.May 15 2023, 8:29 PM

Change 919900 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Collection@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919900

gerritbot added a comment.May 15 2023, 8:32 PM

Change 919901 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ConfirmEdit@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919901

gerritbot added a comment.May 15 2023, 8:38 PM

Change 919902 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LiquidThreads@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919902

gerritbot added a comment.May 15 2023, 8:58 PM

Change 919890 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919890

gerritbot added a comment.May 16 2023, 12:32 AM

Change 919891 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919891

Jdforrester-WMF updated the task description. (Show Details)May 16 2023, 9:20 AM
Jdforrester-WMF updated the task description. (Show Details)May 16 2023, 9:25 AM
Jdforrester-WMF updated the task description. (Show Details)May 16 2023, 9:28 AM
gerritbot added a comment.May 16 2023, 9:47 AM

Change 919899 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Replace $wgOut with Article::getContext()

https://gerrit.wikimedia.org/r/919899

gerritbot added a comment.May 16 2023, 10:01 AM

Change 919889 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919889

gerritbot added a comment.May 16 2023, 10:14 AM

Change 919893 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919893

gerritbot added a comment.May 16 2023, 10:18 AM

Change 919901 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919901

gerritbot added a comment.May 16 2023, 10:18 AM

Change 919892 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919892

gerritbot added a comment.May 16 2023, 10:20 AM

Change 919900 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919900

gerritbot added a comment.May 16 2023, 2:45 PM

Change 919902 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919902

gerritbot added a comment.May 16 2023, 2:45 PM

Change 919884 merged by jenkins-bot:

[mediawiki/extensions/3D@master] Replace $wgOut with RequestContext::getMain()

https://gerrit.wikimedia.org/r/919884

Maintenance_bot removed a project: Patch-For-Review.May 16 2023, 3:11 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 10:01 PM
Pppery added projects: MediaWiki-extensions-Wikibase-Repo, StructuredDiscussions, MediaWiki-extensions-LiquidThreads.Oct 12 2024, 4:29 AM
Pppery updated the task description. (Show Details)
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 12 2024, 4:29 AM
Maintenance_bot added a project: Wikidata.Oct 12 2024, 4:29 AM
Restricted Application added a project: wmde-wikidata-tech. · View Herald TranscriptOct 12 2024, 4:29 AM
Pppery removed projects: StructuredDiscussions, Growth-Team.Oct 14 2024, 5:30 PM
Pppery removed a project: MediaWiki-extensions-LiquidThreads.Oct 14 2024, 5:35 PM
Pppery subscribed.
Pppery unsubscribed.
Lucas_Werkmeister_WMDE subscribed.Oct 18 2024, 10:40 AM

The $wgOut usage in Wikibase is closely tied to a similar pattern in MediaWiki core:

Wikibase FederatedPropertiesError::report()
global $wgOut;
$wgOut->addModuleStyles( [ 'wikibase.alltargets' ] );
// T324991
if ( !WikibaseRepo::getMobileSite() ) {
	$wgOut->addModuleStyles( [ 'wikibase.desktop' ] );
}
parent::report( $action );
core ErrorPageError::report()
global $wgOut;
$wgOut->showErrorPage( $this->title, $this->msg, $this->params );
// (snip)
if ( $action === self::SEND_OUTPUT ) {
	$wgOut->output();
}

So IMHO it would be helpful to know how this is going to be fixed in MediaWiki core before fixing the Wikibase case. There’s even a relevant TODO comment in one of the two places calling that method:

ActionEntryPoint::execute()
// TODO: Should ErrorPageError::report accept a OutputPage parameter?
$e->report( ErrorPageError::STAGE_OUTPUT );

(I suspect the answer to that question is “yes.”)

ItamarWMDE moved this task from Incoming to Radar on the wmde-wikidata-tech board.Oct 24 2024, 12:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits