Page MenuHomePhabricator

MediaWiki core needs uses of $wgOut removed
Open, MediumPublic

Event Timeline

DannyS712 triaged this task as Medium priority.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Change 596904 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/VipsScaler@master] Remove hard deprecate QuickTemplate::msgWiki

https://gerrit.wikimedia.org/r/596904

Change 596904 abandoned by DannyS712:
Remove hard deprecate QuickTemplate::msgWiki

Reason:
wrong repo :(

https://gerrit.wikimedia.org/r/596904

Change 596905 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove hard deprecate QuickTemplate::msgWiki

https://gerrit.wikimedia.org/r/596905

Change 596905 abandoned by DannyS712:
Remove hard deprecated QuickTemplate::msgWiki and BaseTemplate::msgWiki

Reason:
already done

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /596905

DannyS712 renamed this task from Remove core uses of $wgOut to MediaWiki core needs uses of $wgOut removed.Jul 6 2020, 7:31 AM

Change 609626 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] FileDeleteForm: Prepare for dependency injection

https://gerrit.wikimedia.org/r/609626

Change 609626 merged by jenkins-bot:
[mediawiki/core@master] FileDeleteForm: Inject OutputPage instance

https://gerrit.wikimedia.org/r/609626

Change 626437 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] FeedUtils::checkFeedOutput add $output parameter

https://gerrit.wikimedia.org/r/626437

Change 626438 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GoogleNewsSitemap@master] Pass an OutputPage to FeedUtils::checkFeedOutput

https://gerrit.wikimedia.org/r/626438

Change 626437 merged by jenkins-bot:
[mediawiki/core@master] FeedUtils::checkFeedOutput add $output parameter

https://gerrit.wikimedia.org/r/626437

Change #626438 merged by jenkins-bot:

[mediawiki/extensions/GoogleNewsSitemap@master] Pass an OutputPage to FeedUtils::checkFeedOutput

https://gerrit.wikimedia.org/r/626438

Change #1239506 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] FeedUtils: Deprecate passing null to $output in checkFeedOutput

https://gerrit.wikimedia.org/r/1239506

Change #1239506 merged by jenkins-bot:

[mediawiki/core@master] FeedUtils: Deprecate passing null to $output in checkFeedOutput

https://gerrit.wikimedia.org/r/1239506

Change #1243233 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] ErrorPageError: Replace ::report with ::showError

https://gerrit.wikimedia.org/r/1243233

@SomeRandomDeveloper It seems to me that it would be nice to make a push to have your open change land in MW 1.46, to get wgOut on track for deprecation in a few versions. What do you think?

IIRC I wanted to take a slightly different approach than the current version of the patch, which is why I didn't rebase it anymore; I can look into that in the next days.

Change #1281603 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] FeedUtils: Enforce passing an OutputPage to checkFeedOutput()

https://gerrit.wikimedia.org/r/1281603

Change #1281603 merged by jenkins-bot:

[mediawiki/core@master] FeedUtils: Enforce passing an OutputPage to checkFeedOutput()

https://gerrit.wikimedia.org/r/1281603