Page MenuHomePhabricator
Create Task
Maniphest T252979

MediaWiki core needs uses of $wgOut removed
Open, MediumPublic
Actions

Description

Core uses: https://codesearch.wmflabs.org/core/?q=global%5B%5E%3B%5D%2B%5C%24wgOut%5B%2C%3B%5D&i=nope&files=&repos=

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+14 -5FeedUtils::checkFeedOutput add $output parameter
mediawiki/extensions/GoogleNewsSitemapmaster+3 -3Pass an OutputPage to FeedUtils::checkFeedOutput
mediawiki/coremaster+54 -52FileDeleteForm: Inject OutputPage instance
mediawiki/coremaster+2 -21Remove hard deprecated QuickTemplate::msgWiki and BaseTemplate::msgWiki
mediawiki/extensions/VipsScalermaster+0 -0Remove hard deprecate QuickTemplate::msgWiki
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT11968 Reduce use of global and public variables
 OpenNoneT159283 Deprecate non-configuration globals
 OpenNoneT160812 Deprecate $wgOut
 OpenNoneT252979 MediaWiki core needs uses of $wgOut removed

Event Timeline

DannyS712 triaged this task as Medium priority.May 18 2020, 2:19 AM
DannyS712 created this task.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
gerritbot added a comment.May 18 2020, 2:22 AM

Change 596904 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/VipsScaler@master] Remove hard deprecate QuickTemplate::msgWiki

https://gerrit.wikimedia.org/r/596904

gerritbot added a project: Patch-For-Review.May 18 2020, 2:22 AM

Change 596904 abandoned by DannyS712:
Remove hard deprecate QuickTemplate::msgWiki

Reason:
wrong repo :(

https://gerrit.wikimedia.org/r/596904

gerritbot added a comment.May 18 2020, 2:22 AM

Change 596905 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove hard deprecate QuickTemplate::msgWiki

https://gerrit.wikimedia.org/r/596905

gerritbot added a comment.Jul 2 2020, 5:41 AM

Change 596905 abandoned by DannyS712:
Remove hard deprecated QuickTemplate::msgWiki and BaseTemplate::msgWiki

Reason:
already done

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /596905

Maintenance_bot removed a project: Patch-For-Review.Jul 2 2020, 6:10 AM
DannyS712 renamed this task from Remove core uses of $wgOut to MediaWiki core needs uses of $wgOut removed.Jul 6 2020, 7:31 AM
gerritbot added a comment.Jul 6 2020, 7:33 AM

Change 609626 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] FileDeleteForm: Prepare for dependency injection

https://gerrit.wikimedia.org/r/609626

gerritbot added a project: Patch-For-Review.Jul 6 2020, 7:33 AM
gerritbot added a comment.Sep 3 2020, 7:28 PM

Change 609626 merged by jenkins-bot:
[mediawiki/core@master] FileDeleteForm: Inject OutputPage instance

https://gerrit.wikimedia.org/r/609626

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 3 2020, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 3 2020, 8:10 PM
gerritbot added a comment.Sep 10 2020, 10:46 PM

Change 626437 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] FeedUtils::checkFeedOutput add $output parameter

https://gerrit.wikimedia.org/r/626437

gerritbot added a project: Patch-For-Review.Sep 10 2020, 10:46 PM

Change 626438 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GoogleNewsSitemap@master] Pass an OutputPage to FeedUtils::checkFeedOutput

https://gerrit.wikimedia.org/r/626438

gerritbot added a comment.Sep 11 2020, 3:09 PM

Change 626437 merged by jenkins-bot:
[mediawiki/core@master] FeedUtils::checkFeedOutput add $output parameter

https://gerrit.wikimedia.org/r/626437

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.9; 2020-09-15); removed MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 11 2020, 4:01 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL