Details

Backup Train Conductor: Jdforrester-WMF
Release Version: 1.35.0-wmf.34
Release Date: May 25 2020, 12:00 AM

2020 week 22 1.35-wmf.34 Changes wmf/1.35.0-wmf.34

This MediaWiki Train Deployment is scheduled for the week of Monday, May 25th:

Monday May 25th	Tuesday, May 26th	Wednesday, May 27th	Thursday, May 28th	Friday
Backports only.	Branch `wmf.34` and deploy to Group 0 Wikis.	Deploy `wmf.34` to Group 1 Wikis.	Deploy `wmf.34` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.34 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.35.0-wmf.33

Next: 1.35.0-wmf.35

	Project	Branch	Lines +/-	Subject
	mediawiki/core	wmf/1.35.0-wmf.34	+956 -3	Branch commit for wmf/1.35.0-wmf.34

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		ovasileva	T252800 Regression: Option add links in other languages has disappeared
Resolved	Release	mmodell	T253022 1.35.0-wmf.34 deployment blockers
Resolved	PRODUCTION ERROR	DannyS712	T253725 Call to a member function getUser() on boolean ( CoreParserFunctions::revisionuser ?)
Resolved	PRODUCTION ERROR	Nikerabbit	T253748 Fatal: Class 'MessageIndexException' not found
Resolved		mmodell	T253756 No localisation cache found for English. Please run maintenance/rebuildLocalisationCache.php. in production when running populateSitesTable for aawikibooks with foreachwikiindblist
Resolved	PRODUCTION ERROR	Addshore	T253804 Exception from TermStoreWriterFactory : Local entity source does not have items.
Duplicate		• zeljkofilipin	T253049 selenium-daily-betacommons-MediaWiki fails with `internal_api_error_LogicException: [...] Exception caught: Local entity source does not have items.`
Resolved		Jdlrobson	T253905 Vector page layout corrupted on cached pages
Resolved		DannyS712	T253909 Global group membership cannot be changed
Resolved	PRODUCTION ERROR	Reedy	T253922 PHP "cannot access private method LocalRepo::passThrough" from SpecialUpload->processUpload

Event Timeline

thcipriani created this task.May 18 2020, 2:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 18 2020, 2:09 PM

thcipriani assigned this task to mmodell.May 20 2020, 3:28 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: Jdforrester-WMF.

thcipriani added a project: Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)).

thcipriani moved this task from INBOX to Deployment on the Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)) board.

I am not sure if this is really a blocker but perhaps train should not "depart" before ensuring that the updateCollation script from T253559 hasn't finished. Docs say the script can take some time, and while nnwiki is not one of the biggest wikis, it may take a while.

@MarcoAurelio reasoning is that we should avoid running long term maintenance script while updating the train and that updateCollation might take a while. Given nnwiki is not that big, it should not be a problem though ;)

BEANS-X2 added a subscriber: BEANS-X2.May 26 2020, 12:50 PM

Mentioned in SAL (#wikimedia-operations) [2020-05-26T17:16:51Z] <James_F> 1.35.0-wmf.34 was branched at b5012a1e7d0bbd2bf7444b8708d421992bcbe2fb for T253022

Change 598803 had a related patch set uploaded (by Jforrester; owner: trainbranchbot):
[mediawiki/core@wmf/1.35.0-wmf.34] Branch commit for wmf/1.35.0-wmf.34

https://gerrit.wikimedia.org/r/598803

gerritbot added a project: Patch-For-Review.May 26 2020, 5:20 PM

Jdforrester-WMF added a parent task: T252800: Regression: Option add links in other languages has disappeared.May 26 2020, 5:37 PM

Change 598803 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.34] Branch commit for wmf/1.35.0-wmf.34

https://gerrit.wikimedia.org/r/598803

DannyS712 added a subscriber: DannyS712.May 26 2020, 5:46 PM

Change 598824 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] testwikis wikis to 1.35.0-wmf.34 refs T253022

https://gerrit.wikimedia.org/r/598824

Change 598824 merged by jenkins-bot:
[operations/mediawiki-config@master] testwikis wikis to 1.35.0-wmf.34 refs T253022

https://gerrit.wikimedia.org/r/598824

Mentioned in SAL (#wikimedia-operations) [2020-05-26T18:58:08Z] <twentyafterfour@deploy1001> Started scap: testwikis wikis to 1.35.0-wmf.34 refs T253022

Mentioned in SAL (#wikimedia-operations) [2020-05-26T20:08:10Z] <twentyafterfour@deploy1001> Finished scap: testwikis wikis to 1.35.0-wmf.34 refs T253022 (duration: 70m 02s)

Change 598842 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] group0 wikis to 1.35.0-wmf.34 refs T253022

https://gerrit.wikimedia.org/r/598842

Change 598842 merged by jenkins-bot:
[operations/mediawiki-config@master] group0 wikis to 1.35.0-wmf.34 refs T253022

https://gerrit.wikimedia.org/r/598842

Mentioned in SAL (#wikimedia-operations) [2020-05-26T20:29:22Z] <twentyafterfour@deploy1001> rebuilt and synchronized wikiversions files: group0 wikis to 1.35.0-wmf.34 refs T253022

@deployers if any Revision work bugs are found during the train log triage (11:00–12:00 PDT), please note that I may not be available to fix them; I'm donating blood right before that. I'll try to check if I broke anything as soon as I can, but just a heads up that help would be appreciated.

hashar added a subtask: T253725: Call to a member function getUser() on boolean ( CoreParserFunctions::revisionuser ?).May 27 2020, 8:03 AM

DannyS712 added a project: User-DannyS712.May 27 2020, 8:42 AM

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Krinkle added a subtask: T253748: Fatal: Class 'MessageIndexException' not found.May 27 2020, 12:43 PM

Krinkle added a subtask: T253756: No localisation cache found for English. Please run maintenance/rebuildLocalisationCache.php. in production when running populateSitesTable for aawikibooks with foreachwikiindblist.May 27 2020, 3:24 PM

Mentioned in SAL (#wikimedia-operations) [2020-05-27T17:32:25Z] <twentyafterfour@deploy1001> Synchronized php-1.35.0-wmf.34/extensions/Translate/: Deploy https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Translate/+/599027/ to wmf.34 refs T253748 and T253022 (duration: 01m 07s)

Stashbot mentioned this in T253748: Fatal: Class 'MessageIndexException' not found.May 27 2020, 5:32 PM

thcipriani closed subtask T253748: Fatal: Class 'MessageIndexException' not found as Resolved.May 27 2020, 6:07 PM

mmodell closed subtask T253756: No localisation cache found for English. Please run maintenance/rebuildLocalisationCache.php. in production when running populateSitesTable for aawikibooks with foreachwikiindblist as Resolved.May 27 2020, 6:35 PM

Change 599110 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] group1 wikis to 1.35.0-wmf.34 refs T253022

https://gerrit.wikimedia.org/r/599110

Jdforrester-WMF closed subtask T253725: Call to a member function getUser() on boolean ( CoreParserFunctions::revisionuser ?) as Resolved.May 27 2020, 7:51 PM

Change 599110 merged by jenkins-bot:
[operations/mediawiki-config@master] group1 wikis to 1.35.0-wmf.34 refs T253022

https://gerrit.wikimedia.org/r/599110

mmodell added a subtask: T253804: Exception from TermStoreWriterFactory : Local entity source does not have items..May 27 2020, 8:00 PM

Change 599111 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] group1 wikis to 1.35.0-wmf.32 refs T253022

https://gerrit.wikimedia.org/r/599111

Change 599111 merged by jenkins-bot:
[operations/mediawiki-config@master] group1 wikis to 1.35.0-wmf.32 refs T253022

https://gerrit.wikimedia.org/r/599111

Mentioned in SAL (#wikimedia-operations) [2020-05-27T20:03:21Z] <twentyafterfour@deploy1001> rebuilt and synchronized wikiversions files: group1 wikis to 1.35.0-wmf.32 refs T253022

Mentioned in SAL (#wikimedia-operations) [2020-05-27T20:04:27Z] <twentyafterfour@deploy1001> Synchronized php: group1 wikis to 1.35.0-wmf.32 refs T253022 (duration: 01m 04s)

rolling to group1 caused errors on commons which was caught by canary checks, see T253804: Exception from TermStoreWriterFactory : Local entity source does not have items.

Jdforrester-WMF closed subtask T253804: Exception from TermStoreWriterFactory : Local entity source does not have items. as Resolved.May 28 2020, 4:33 PM

Change 599386 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] group1 wikis to 1.35.0-wmf.34 refs T253022

https://gerrit.wikimedia.org/r/599386

Change 599386 merged by jenkins-bot:
[operations/mediawiki-config@master] group1 wikis to 1.35.0-wmf.34 refs T253022

https://gerrit.wikimedia.org/r/599386

Mentioned in SAL (#wikimedia-operations) [2020-05-28T17:02:42Z] <twentyafterfour@deploy1001> rebuilt and synchronized wikiversions files: group1 wikis to 1.35.0-wmf.34 refs T253022

Mentioned in SAL (#wikimedia-operations) [2020-05-28T17:03:49Z] <twentyafterfour@deploy1001> Synchronized php: group1 wikis to 1.35.0-wmf.34 refs T253022 (duration: 01m 06s)

Change 599406 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] all wikis to 1.35.0-wmf.34 refs T253022

https://gerrit.wikimedia.org/r/599406

Change 599406 merged by jenkins-bot:
[operations/mediawiki-config@master] all wikis to 1.35.0-wmf.34 refs T253022

https://gerrit.wikimedia.org/r/599406

Mentioned in SAL (#wikimedia-operations) [2020-05-28T19:14:37Z] <twentyafterfour@deploy1001> rebuilt and synchronized wikiversions files: all wikis to 1.35.0-wmf.34 refs T253022

Krinkle added a subtask: T253905: Vector page layout corrupted on cached pages.May 28 2020, 7:15 PM

Change 599411 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] group2 wikis to 1.35.0-wmf.32 refs T253022

https://gerrit.wikimedia.org/r/599411

Change 599411 merged by jenkins-bot:
[operations/mediawiki-config@master] group2 wikis to 1.35.0-wmf.32 refs T253022

https://gerrit.wikimedia.org/r/599411

RhinosF1 added a subscriber: RhinosF1.May 28 2020, 7:26 PM

mdaniels5757 added a subscriber: mdaniels5757.May 28 2020, 7:29 PM

Urbanecm added a subtask: T253909: Global group membership cannot be changed.May 28 2020, 8:02 PM

Krinkle added a subtask: T253922: PHP "cannot access private method LocalRepo::passThrough" from SpecialUpload->processUpload.May 28 2020, 8:52 PM

Jdforrester-WMF closed subtask T253905: Vector page layout corrupted on cached pages as Resolved.May 28 2020, 8:54 PM

Huji mentioned this in T252800: Regression: Option add links in other languages has disappeared.May 28 2020, 9:05 PM

Jdforrester-WMF closed subtask T253909: Global group membership cannot be changed as Resolved.May 28 2020, 9:12 PM

Jdforrester-WMF closed subtask T253922: PHP "cannot access private method LocalRepo::passThrough" from SpecialUpload->processUpload as Resolved.May 28 2020, 9:26 PM

Agusbou2015 added a subscriber: Agusbou2015.May 28 2020, 9:38 PM