1.35.0-wmf.35 deployment blockers
Closed, ResolvedPublicRelease
Actions

Assigned To

Authored By

	thcipriani
	May 18 2020, 2:09 PM

Details

Backup Train Conductor: jeena
Release Version: 1.35.0-wmf.35
Release Date: Jun 1 2020, 12:00 AM

2020 week 23 1.35-wmf.35 Changes wmf/1.35.0-wmf.35

This MediaWiki Train Deployment is scheduled for the week of Monday, June 1st:

Monday June 1st	Tuesday, June 2nd	Wednesday, June 3rd	Thursday, June 4th	Friday
Backports only.	Branch `wmf.35` and deploy to Group 0 Wikis.	Deploy `wmf.35` to Group 1 Wikis.	Deploy `wmf.35` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.35 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.35.0-wmf.34

Next: 1.35.0-wmf.36

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	Jdforrester-WMF	T253023 1.35.0-wmf.35 deployment blockers
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T254390 Argument 1 passed to MediaWiki\Extension\EventStreamConfig\ApiStreamConfigs::multiParamToAssocArray() must be of the type array, null given, called in /srv/mediawiki/php-1.35.0-wmf.35/extensions/EventStreamConfig/includes/ApiStreamConfigs.php on line 66
Resolved	PRODUCTION ERROR	DannyS712	T254417 SpecialUserrights.php: Call to undefined method CentralAuthGroupMembershipProxy::canReceiveEmail()
Resolved	PRODUCTION ERROR	Tgr	T254699 PHP Warning: "Invalid argument supplied for foreach()" from ApiEchoMute.php

Event Timeline

thcipriani created this task.May 18 2020, 2:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 18 2020, 2:09 PM

thcipriani assigned this task to Jdforrester-WMF.May 26 2020, 9:20 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: jeena.

thcipriani added a project: Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)).

thcipriani moved this task from INBOX to Deployment on the Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)) board.

@Jdforrester-WMF Based on request from @thcipriani I'm adding a heads up note here, the Hooks changes @tstarling and @nnikkhoui built will be riding the train the week of June 1st.

This patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/581225

We ran a pilot test this week with a much smaller patch and thus far is stable. The above patch will merge on Friday May 29th.

CPT's Clinic Duty Team will be paying attention next week to the logs and at the train log triage meeting for this specific patch. Let me know if there is anything else we can do to help out or support.

Ack. Thanks for the heads-up.

In T253023#6173804, @WDoranWMF wrote:

@Jdforrester-WMF Based on request from @thcipriani I'm adding a heads up note here, the Hooks changes @tstarling and @nnikkhoui built will be riding the train the week of June 1st.

This patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/581225

I have just hit +2 on this.

I looked around phabricator but didn't see any new bugs reported that might be related to the pilot patch, but I didn't see anything suspicious.

If anything goes wrong with this patch, I think the most likely type of error will be silent kind, where an extension simply stops functioning, because some hook parameter that is is modifying is no longer being passed by reference. We took great care to resolve any such issues beforehand, but that's still what I would watch out for.

DannyS712 subscribed.Jun 1 2020, 7:42 AM

Mentioned in SAL (#wikimedia-operations) [2020-06-02T17:20:21Z] <James_F> 1.35.0-wmf.35 was branched at 8d7015037d44c4fe21eee8e8a040720b838bc169 for T253023

Mentioned in SAL (#wikimedia-operations) [2020-06-03T19:20:31Z] <jforrester@deploy1001> rebuilt and synchronized wikiversions files: Revert group1 wikis to wmf.34 T253023

Jdforrester-WMF added a subtask: T254390: Argument 1 passed to MediaWiki\Extension\EventStreamConfig\ApiStreamConfigs::multiParamToAssocArray() must be of the type array, null given, called in /srv/mediawiki/php-1.35.0-wmf.35/extensions/EventStreamConfig/includes/ApiStreamConfigs.php on line 66.Jun 3 2020, 7:21 PM

Jdforrester-WMF closed subtask T254390: Argument 1 passed to MediaWiki\Extension\EventStreamConfig\ApiStreamConfigs::multiParamToAssocArray() must be of the type array, null given, called in /srv/mediawiki/php-1.35.0-wmf.35/extensions/EventStreamConfig/includes/ApiStreamConfigs.php on line 66 as Resolved.Jun 3 2020, 9:53 PM

Mentioned in SAL (#wikimedia-operations) [2020-06-03T21:54:16Z] <jforrester@deploy1001> rebuilt and synchronized wikiversions files: Re-rolling group1 to 1.35.0-wmf.35 for T253023

Reedy closed subtask T254417: SpecialUserrights.php: Call to undefined method CentralAuthGroupMembershipProxy::canReceiveEmail() as Resolved.Jun 4 2020, 12:36 AM