Multiversion bug in relative module_deps path
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	May 18 2020, 7:03 PM

Description

| skins.vector.styles.legacy        | vector|en-gb | ["../php-1.35.0-wmf.31/resources/src/mediawiki.less/mediawiki.mixins.less","../php-1.35.0-wmf.31/resources/src/mediawiki.skinning/i18n-all-lists-margins.less","../php-1.35.0-wmf.31/resources/src/mediawiki.skinning/i18n-headings.less","../php-1.35.0-wmf.31/resources/src/mediawiki.skinning/i18n-ordered-lists.less","resources/src/mediawiki.less/mediawiki.mixins.animation.less","resources/src/mediawiki.less/mediawiki.mixins.less","resources/src/mediawiki.less/mediawiki.mixins.rotation.less","resources/src/mediawiki.less/mediawiki.ui/variables.less","resources/src/mediawiki.skinning/images/ajax-loader.gif","resources/src/mediawiki.skinning/images/magnify-clip-ltr.png","resources/src/mediawiki.skinning/images/magnify-clip-ltr.svg","resources/src/mediawiki.skinning/images/magnify-clip-rtl.png","resources/src/mediawiki.skinning/images/magnify-clip-rtl.svg","resources/src/mediawiki.skinning/images/spinner.gif","skins/Vector/resources/skins.vector.styles/Footer.less","skins/Vector/resources/skins.vector.styles/Indicators.less","skins/Vector/resources/skins.vector.styles/Menu.less","skins/Vector/resources/skins.vector.styles/MenuDropdown.less",…] |

Something is going wrong here with the $IP-relative path expansion. For some reason despite this wiki being on 1.35.0-wmf.32 (test2wiki today), it is newly writing the above row which points to a wmf.31 patch.

Details

	Subject	Repo	Branch	Lines +/-
	resourceloader: store relative paths in less compilation cache	mediawiki/core	master	+32 -27

Customize query in gerrit

Event Timeline

Krinkle created this task.May 18 2020, 7:03 PM

Restricted Application added a project: Performance-Team. · View Herald TranscriptMay 18 2020, 7:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Krinkle updated the task description. (Show Details)May 18 2020, 7:03 PM

• Gilles added a project: EngProd-Virtual-Hackathon.May 20 2020, 4:13 PM

• Gilles moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.

Krinkle assigned this task to aaron.May 20 2020, 4:25 PM

Krinkle triaged this task as High priority.Jun 15 2020, 11:27 PM

Krinkle moved this task from Inbox to Confirmed Problem on the MediaWiki-ResourceLoader board.

Change 612687 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] resourceloader: store relative paths in less compilation cache

https://gerrit.wikimedia.org/r/612687

gerritbot added a project: Patch-For-Review.Jul 15 2020, 12:26 AM

Krinkle moved this task from Backlog: Maintenance, non-prioritized to Doing (old) on the Performance-Team board.Jul 20 2020, 8:23 PM

Change 612687 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: store relative paths in less compilation cache

https://gerrit.wikimedia.org/r/612687

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.2; 2020-07-28).Jul 25 2020, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 25 2020, 12:10 AM

Krinkle lowered the priority of this task from High to Medium.Jul 29 2020, 2:09 AM

aaron closed this task as Resolved.Aug 10 2020, 8:11 PM