Convert UserCache to a service with dependency injection
Closed, ResolvedPublic
Actions

Description

Currently, UserCache is retrieved through UserCache::singleton, and the actual constructor is protected. Within the class, it uses a debugger (currently via wfDebug), a load balancer (currently retrieves a database via wfGetDB) and a LinkBatch object.

I propose that this be converted to a service:

A \Psr\Log\LoggerInterface is injected
A Wikimedia\Rdbms\ILoadBalancer is injected
A MediaWiki\Cache\LinkBatchFactory is injected

The singleton method can be deprecated, and since the constructor isn't public there is no need for backwards compatibility with the current signature (no params at all). Codesearch reports that nothing currently extends the class

Details

	Subject	Repo	Branch	Lines +/-
	Inject UserCache into SpecialListFiles/SpecialNewFiles	mediawiki/core	master	+18 -4
	Convert UserCache to a service	mediawiki/core	master	+56 -10

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T259960 Inject services into API modules and special pages
		Resolved		DannyS712	T253061 Convert UserCache to a service with dependency injection

Event Timeline

DannyS712 created this task.May 18 2020, 8:11 PM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptMay 18 2020, 8:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.May 18 2020, 8:12 PM

DannyS712 updated the task description. (Show Details)May 18 2020, 8:16 PM

Change 597150 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Convert UserCache to a service

https://gerrit.wikimedia.org/r/597150

gerritbot added a project: Patch-For-Review.May 18 2020, 8:43 PM

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.May 18 2020, 8:44 PM

Krinkle edited projects, added MediaWiki-General; removed MediaWiki-libs-BagOStuff.Jul 30 2020, 10:18 PM

• eprodromou triaged this task as Low priority.Sep 8 2020, 8:59 PM

Umherirrender added a parent task: T259960: Inject services into API modules and special pages.Oct 13 2020, 7:38 PM

Umherirrender removed a parent task: T259960: Inject services into API modules and special pages.

Umherirrender added a subtask: T259960: Inject services into API modules and special pages.

Umherirrender removed a subtask: T259960: Inject services into API modules and special pages.Oct 13 2020, 8:15 PM

Umherirrender added a parent task: T259960: Inject services into API modules and special pages.

Change 597150 merged by jenkins-bot:
[mediawiki/core@master] Convert UserCache to a service

https://gerrit.wikimedia.org/r/597150

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 20 2020, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 20 2020, 9:11 PM

Change 635574 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Inject UserCache into SpecialListFiles/SpecialNewFiles

https://gerrit.wikimedia.org/r/635574

gerritbot added a project: Patch-For-Review.Oct 21 2020, 4:35 PM

Change 635574 merged by jenkins-bot:
[mediawiki/core@master] Inject UserCache into SpecialListFiles/SpecialNewFiles

https://gerrit.wikimedia.org/r/635574

Maintenance_bot removed a project: Patch-For-Review.Oct 22 2020, 12:10 AM

DannyS712 closed this task as Resolved.Nov 29 2020, 9:50 PM