Page MenuHomePhabricator
Create Task
Maniphest T253077

Convert MWGrants to a service with dependency injection
Open, Needs TriagePublic
Actions

Description

Similar to how MWNamespace was replaced with a NamespaceInfo service, I propose that MWGrants be replaced with a GrantsInfo service.

The different static MWGrants methods use:

  • The LanguageFactory service
  • The LinkRenderer service
  • The ContentLanguage service (which is just the LanguageFactory with the LanguageCode config value)
  • wgGrantPermissions
  • wgGrantPermissionGroups

The services can be injected to the new GrantsInfo class, as well as a ServiceOptions object with the needed configuration values

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+50 -11Hard deprecated the MWGrants class
mediawiki/coremaster+30 -10Use GrantsInfo and GrantsLocalization instead of MWGrants
mediawiki/extensions/TuleapWikiFarmmaster+13 -1Use GrantsInfo instead of MWGrants
mediawiki/coremaster+56 -23BotPasswordSessionProvider: inject GrantsInfo
mediawiki/extensions/OAuthmaster+151 -38Use GrantsInfo and GrantsLocalization instead of MWGrants
mediawiki/coremaster+613 -99Reapply "GrantsInfo service to replace MWGrants"
mediawiki/coremaster+421 -99Reapply "GrantsInfo service to replace MWGrants"
mediawiki/coremaster+99 -421Revert "GrantsInfo service to replace MWGrants"
mediawiki/coremaster+421 -99GrantsInfo service to replace MWGrants
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.May 18 2020, 10:33 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptMay 18 2020, 10:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.May 18 2020, 10:33 PM
DannyS712 added a project: Platform Engineering.May 29 2020, 3:46 AM

Tagging core platform team per https://www.mediawiki.org/wiki/Developers/Maintainers

• Pchelolo moved this task from Inbox to Triage Meeting Inbox on the Platform Engineering board.Jun 2 2020, 2:44 PM
• Pchelolo moved this task from Triage Meeting Inbox to Volunteer Needed Tasks on the Platform Engineering board.Jun 2 2020, 5:25 PM
• Pchelolo added a subscriber: • Pchelolo.

Makes sense to me. The getGrantsLink and getGrantsWikiText are quite a bit more UI-related, so it would be interesting to think if we could put them elsewhere.

getGrantsWikiText is only used in OAuth extension special pages, so we could maybe just move this code in there, perhaps in a trait used in both special pages.

getGrantsLink is more tricky, but we can maybe find it a better home too. Not sure where yet.

Umherirrender added a subtask: T259960: Inject services into API modules and special pages.Oct 13 2020, 7:38 PM
Umherirrender removed a subtask: T259960: Inject services into API modules and special pages.Oct 13 2020, 8:14 PM
Umherirrender added a parent task: T259960: Inject services into API modules and special pages.
gerritbot added a comment.Jun 1 2021, 9:42 PM

Change 697673 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] [WIP] GrantsInfo service to replace MWGrants

https://gerrit.wikimedia.org/r/697673

gerritbot added a project: Patch-For-Review.Jun 1 2021, 9:42 PM
Zabe added a subscriber: Zabe.Jun 1 2021, 9:42 PM
gerritbot added a comment.Jun 11 2021, 6:24 AM

Change 697673 merged by jenkins-bot:

[mediawiki/core@master] GrantsInfo service to replace MWGrants

https://gerrit.wikimedia.org/r/697673

Maintenance_bot removed a project: Patch-For-Review.Jun 11 2021, 7:10 AM
gerritbot added a comment.Jun 11 2021, 5:17 PM

Change 699300 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[mediawiki/core@master] Revert "GrantsInfo service to replace MWGrants"

https://gerrit.wikimedia.org/r/699300

gerritbot added a project: Patch-For-Review.Jun 11 2021, 5:17 PM
gerritbot added a comment.Jun 11 2021, 5:40 PM

Change 699300 merged by jenkins-bot:

[mediawiki/core@master] Revert "GrantsInfo service to replace MWGrants"

https://gerrit.wikimedia.org/r/699300

Maintenance_bot removed a project: Patch-For-Review.Jun 11 2021, 6:11 PM
valhallasw mentioned this in T284587: ReleaseTaggerBot skipping some Tasks/Patches?.Jun 12 2021, 8:03 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 12 2021, 8:11 PM
Zabe claimed this task.Jul 22 2021, 10:26 AM
Zabe added a project: User-Zabe.
gerritbot added a comment.Aug 6 2021, 7:42 PM

Change 710557 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Reapply \"GrantsInfo service to replace MWGrants\"

https://gerrit.wikimedia.org/r/710557

gerritbot added a project: Patch-For-Review.Aug 6 2021, 7:42 PM
gerritbot added a comment.Aug 6 2021, 7:49 PM

Change 710557 abandoned by Zabe:

[mediawiki/core@master] Reapply \"GrantsInfo service to replace MWGrants\"

Reason:

going to reupload a new patch manually rebased and the issue addressed

https://gerrit.wikimedia.org/r/710557

Maintenance_bot removed a project: Patch-For-Review.Aug 6 2021, 8:10 PM
gerritbot added a comment.Aug 6 2021, 8:36 PM

Change 710608 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Reapply \"GrantsInfo service to replace MWGrants\"

https://gerrit.wikimedia.org/r/710608

gerritbot added a project: Patch-For-Review.Aug 6 2021, 8:36 PM
gerritbot added a comment.Sep 18 2021, 10:04 AM

Change 710608 merged by jenkins-bot:

[mediawiki/core@master] Reapply \"GrantsInfo service to replace MWGrants\"

https://gerrit.wikimedia.org/r/710608

Maintenance_bot removed a project: Patch-For-Review.Sep 18 2021, 10:10 AM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 18 2021, 11:00 AM
gerritbot added a comment.Sep 22 2021, 9:28 PM

Change 722957 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/OAuth@master] Use GrantsInfo and GrantsLocalization instead of MWGrants

https://gerrit.wikimedia.org/r/722957

gerritbot added a project: Patch-For-Review.Sep 22 2021, 9:28 PM
gerritbot added a comment.Sep 22 2021, 9:44 PM

Change 697712 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Use GrantsInfo and GrantsLocalization instead of MWGrants

https://gerrit.wikimedia.org/r/697712

gerritbot added a comment.Dec 26 2021, 5:05 AM

Change 722957 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] Use GrantsInfo and GrantsLocalization instead of MWGrants

https://gerrit.wikimedia.org/r/722957

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.16; 2022-01-03); removed MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Dec 26 2021, 6:00 AM
gerritbot added a comment.Apr 12 2022, 4:27 PM

Change 779502 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] BotPasswordSessionProvider: inject GrantsInfo

https://gerrit.wikimedia.org/r/779502

gerritbot added a comment.Apr 12 2022, 5:10 PM

Change 779502 merged by jenkins-bot:

[mediawiki/core@master] BotPasswordSessionProvider: inject GrantsInfo

https://gerrit.wikimedia.org/r/779502

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.8; 2022-04-18).Apr 12 2022, 6:00 PM
gerritbot added a comment.Apr 13 2022, 12:28 AM

Change 779571 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/TuleapWikiFarm@master] Use GrantsInfo instead of MWGrants

https://gerrit.wikimedia.org/r/779571

Zabe removed a project: User-Zabe.Apr 13 2022, 1:21 AM
gerritbot added a comment.Apr 28 2022, 6:53 AM

Change 779571 merged by Robert Vogel:

[mediawiki/extensions/TuleapWikiFarm@master] Use GrantsInfo instead of MWGrants

https://gerrit.wikimedia.org/r/779571

Osnard mentioned this in rETWFfeabcce75c5f: Use GrantsInfo instead of MWGrants.Apr 28 2022, 6:53 AM
Arlolra mentioned this in T306743: Container Disabled! (JobQueue/RefreshLinksJob/Parser::getTargetLanguageConverter).Apr 28 2022, 4:07 PM
DannyS712 removed a project: User-DannyS712.Jun 3 2022, 9:02 PM
gerritbot added a comment.Jul 10 2022, 6:19 PM

Change 697712 merged by jenkins-bot:

[mediawiki/core@master] Use GrantsInfo and GrantsLocalization instead of MWGrants

https://gerrit.wikimedia.org/r/697712

gerritbot added a comment.Jul 11 2022, 3:00 PM

Change 812882 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Hard deprecated the MWGrants class

https://gerrit.wikimedia.org/r/812882

gerritbot added a comment.Jul 11 2022, 7:31 PM

Change 812882 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecated the MWGrants class

https://gerrit.wikimedia.org/r/812882

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.21; 2022-07-18); removed MW-1.39-notes (1.39.0-wmf.8; 2022-04-18).Jul 12 2022, 6:02 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL