Notes
Adding some notes from the conversation @Esanders and I had today about this.

• It is possible to achieve the behavior this task is describing [i]; however, to achieve this behavior for comments posted with and without DiscussionTools, additional logic would need to be added to create/identify the boundaries of comments posted not posted using DiscussionTool feautres.
  • This "additional logic" is likely now easier to implement now that we we've moved the comment parser code to the server; see: T252252.
• A question remains: "How do we avoid duplicate notifications being sent between two systems (Echo and this to-be written DiscussionTools system)?" [ii.]

i. When someone clicks on a notification, they will be taken to the precise place on the page where that comment-triggering-content exists and that comment-triggering-content could be highlighted/visually accentuated to make it easy for people to notice/identify.
ii. This has been added to the task description under the "Open questions" heading.

Another issue that occurs when there is only partial adoption of DiscussionTools is that if a user who doesn't have DT enabled gets a notification, it may not be possible for us to scroll them to the correct part of the page, as finding the comment requires DT.

As we move from just adding reply links to adding more features like notifications, we need to think about what it means for an individual user to disable discussion tools. Should it even be possible to disable the notification parts of DT, or should the disable just apply to the reply widget? (probably the latter)

In T253082#6271002, @Esanders wrote:

As we move from just adding reply links to adding more features like notifications, we need to think about what it means for an individual user to disable discussion tools. Should it even be possible to disable the notification parts of DT, or should the disable just apply to the reply widget? (probably the latter).

Great spot, Ed; here's a ticket for us to take up this question: T265319 (I need to fill in some more details).

This has already been mostly done with the patch on T265268 ("page is scrolled such that the comment you were mentioned in is visible"), and T281471 implements the remaining part ("you can easily locate the precise comment you were mentioned in").

In T253082#7130581, @matmarex renamed this task from Take the users to the exact location of the comment when clicking on a mention notification to Enhance mention notifications with DiscussionTools (display a snippet, link directly to the comment and highlight it).

The snippet is already there, see the below screenshot. I can imagine that it could be improved in some edge cases, but then that should be stated in the task title, not adding.

Thanks, you're right of course, I copied the title from T281590 without thinking.

Change 683930 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Enhance Echo user talk edit and mention notifs

https://gerrit.wikimedia.org/r/683930

Change 705771 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Add test cases for interactions with events generated by base Echo

https://gerrit.wikimedia.org/r/705771

Change 705771 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Test cases for interactions with events generated by base Echo

https://gerrit.wikimedia.org/r/705771

Change 683930 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Enhance Echo user talk edit and mention notifications

https://gerrit.wikimedia.org/r/683930