The current code spans 2 files and over 300 lines.

Given how easy maniphest.search's api is. I'm pretty sure we can cull a lot of that down.

When I tried to review the code to look at the bug raised today, I had a feeling that it might make sense after an hour.

@Paladox found https://pypi.org/project/phabricator/ which could be better to use

Using requests, my current code is 67 lines & 1 file compared to 342 lines + 2 files but is only about half done.

I may split bits into 2 files over time but in total I expect the code to not exceed 40% of the size of the current one.

The code currently sits at 19.5% of the size.

Assuming I can get past travis, I will merge to dev and assign to @Zppix to update the master version and maybe have GSOC/GCI students write tests.

As it stands, We operate at 111 lines (~34% of the original size) and I could arguably make some stuff even shorter by implementing a backend.

If we want to switch to using a requests based client and reduce duplication, Assign back to me.

modules % pylint --disable=all --enable=duplicate-code phabtest.py

------------------------------------
Your code has been rated at 10.00/10

Is surprising to be honest

Deployed but we seem to have an issue with the response, fixing.

In T253111#6157909, @RhinosF1 wrote:

Deployed but we seem to have an issue with the response, fixing.

Once, I've fixed it to handle no tasks in high pri - I'll open a PR to merge to core and the rest should be follow up tasks personally to refine things.

Please only add T253297 if they need working on asap. General bugs don't need to be part of this as this is about improving code practice.

https://github.com/Pix1234/ZppixBot-Source/pull/142

I will complete a review of the new code and deploy to master later this week.