Page MenuHomePhabricator

SkinTemplateOutputPageBeforeExec is being deprecated. Use SkinAddFooterLink hook
Closed, ResolvedPublic

Description

The SkinTemplateOutputPageBeforeExec hook is being deprecated to support the upcoming refresh of the vector skin (target 1.35 release - see T60137 for background)

The wikidata.org extension uses the hook to add a link to the site footer, however a new and more direct hook serves that purpose - SkinAddFooterLink

I've provided a patch (untested) to resolve this bug. Thanks in advance for your support with code review!

Event Timeline

Restricted Application added a project: Wikidata. · View Herald TranscriptMay 19 2020, 11:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 597389 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Wikidata.org@master] Use SkinAddFooterLink to add links to the footer

https://gerrit.wikimedia.org/r/597389

Change 597389 merged by jenkins-bot:
[mediawiki/extensions/Wikidata.org@master] Use SkinAddFooterLink to add links to the footer

https://gerrit.wikimedia.org/r/597389

Thank you! I'll let you resolve! Not sure if you want to QA.

Addshore closed this task as Resolved.Jun 2 2020, 2:26 PM
Addshore claimed this task.
Restricted Application added a project: User-Addshore. · View Herald TranscriptJun 2 2020, 2:26 PM