SkinTemplateOutputPageBeforeExec is being deprecated. Use SkinAddFooterLink hook
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	May 19 2020, 11:48 PM

Description

The SkinTemplateOutputPageBeforeExec hook is being deprecated to support the upcoming refresh of the vector skin (target 1.35 release - see T60137 for background)

The wikidata.org extension uses the hook to add a link to the site footer, however a new and more direct hook serves that purpose - SkinAddFooterLink

I've provided a patch (untested) to resolve this bug. Thanks in advance for your support with code review!

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use SkinAddFooterLink to add links to the footer	mediawiki/extensions/Wikidata.org	master	+16 -16

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T140664 Achieve predictable MediaWiki routing and cacheable skin data
Resolved	Jdlrobson	T253813 [EPIC] Deprecate the SkinTemplate hooks and simplify the skin<->extension contract.
Resolved	None	T60137 Deprecate the SkinTemplateOutputPageBeforeExec hook
Resolved	Addshore	T253174 SkinTemplateOutputPageBeforeExec is being deprecated. Use SkinAddFooterLink hook

Event Timeline

Jdlrobson created this task.May 19 2020, 11:48 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptMay 19 2020, 11:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 597389 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Wikidata.org@master] Use SkinAddFooterLink to add links to the footer

https://gerrit.wikimedia.org/r/597389

gerritbot added a project: Patch-For-Review.May 19 2020, 11:48 PM

Jdlrobson added a parent task: T60137: Deprecate the SkinTemplateOutputPageBeforeExec hook.May 20 2020, 12:31 AM

Jdlrobson mentioned this in T60137: Deprecate the SkinTemplateOutputPageBeforeExec hook.May 20 2020, 12:34 AM

Jdlrobson mentioned this in T252725: [Spike] SkinTemplateOutputPageBeforeExec is being deprecated. Identify usages and create tasks for fixing.

Addshore added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).May 20 2020, 8:19 AM

Addshore moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 597389 merged by jenkins-bot:
[mediawiki/extensions/Wikidata.org@master] Use SkinAddFooterLink to add links to the footer

https://gerrit.wikimedia.org/r/597389

Maintenance_bot removed a project: Patch-For-Review.May 20 2020, 9:10 AM

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.May 20 2020, 9:15 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 20 2020, 10:00 AM