Convert SiteStats to a service with dependency injection
Open, LowPublic
Actions

Description

Currently, SiteStats is entirely static (documented as Static accessor class for site_stats and related things) forcing it to retrieve dependencies from mediawiki services.

I propose that it be converted to a service, similar to how MWNamespace's static methods were converted to a NamespaceInfo service

Dependencies to be injected:

DBLoadBalancer
LoggerInstance (currently uses wfDebug)
MainWANObjectCache
JobQueueGroup
the config value of MiserMode

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+192 -84	Convert SiteStats to a singleton with dependency injection

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T259960 Inject services into API modules and special pages
		Open		DannyS712	T253184 Convert SiteStats to a service with dependency injection

Event Timeline

DannyS712 created this task.May 20 2020, 1:32 AM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptMay 20 2020, 1:32 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.May 20 2020, 1:32 AM

DannyS712 claimed this task.May 20 2020, 6:38 AM

Change 597488 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add new SiteStatistics service to replace SiteStats

https://gerrit.wikimedia.org/r/597488

gerritbot added a project: Patch-For-Review.May 20 2020, 10:35 AM

DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.May 20 2020, 10:37 AM

DannyS712 added a project: Platform Team Workboards (External Code Reviews).

• eprodromou triaged this task as Low priority.Sep 8 2020, 8:58 PM

Umherirrender added a parent task: T259960: Inject services into API modules and special pages.Oct 15 2020, 7:43 PM