Page MenuHomePhabricator

Implement OOUI Pop-Up in StructuredDiscussions (Flow extension) notifications [MEDIUM]
Open, Needs TriagePublic

Description

As a watchlist expiry user, I want the Pop-Up in StructuredDiscussions to be OOUI, so it remains consistent with the work done on T249259 and so that the users can access the feature via StructuredDiscussions.

Background: This is a task that stems from Dom's comment in the original Pop-Up OOUI ticket.

Acceptance Criteria:

  • The user should be able to watch a page via the star & generate OOUI message in StructuredDiscussions
  • The general behavior should follow the specifications of T249259

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Scardenasmolinar renamed this task from Implement OOUI Pop-Up in Flow notifications to Implement OOUI Pop-Up in StructuredDiscussions (Flow extension) notifications.May 20 2020, 6:00 PM
ARamirez_WMF renamed this task from Implement OOUI Pop-Up in StructuredDiscussions (Flow extension) notifications to Implement OOUI Pop-Up in StructuredDiscussions (Flow extension) notifications [MEDIUM].May 21 2020, 5:14 PM
ARamirez_WMF moved this task from Needs Discussion to Up Next on the Community-Tech board.
Niharika raised the priority of this task from Medium to Needs Triage.
Niharika subscribed.

Whoops sorry I thought this was an AHT task. My bad.

@ifried On a User_talk page which has StructuredDiscussion enabled there can be multiple watchstars. There is the one for the page itself. There is also one for each Topic, e.g.

flow_topic.png (492×1 px, 49 KB)

Should this work apply to these watchstars? (Perhaps it already does.)

Should this work apply to these watchstars? (Perhaps it already does.)

Absolutely no feature development is to be done for StructuredDiscussions (Flow), only bug fixes, since StructuredDiscussions is eventually going to be deprecated in favor of the Editing Team's new Talk page features. Recommend decline.

Yup, I agree with @kaldari. We will not provide support to temporarily watch pages via Structured Discussions for two reasons: 1) The block on feature development for StructuredDiscussions, due to its gradual deprecation, 2) The need for us to limit the scope of our work to only the most critical elements of the feature.

One question for @dom_walden: If a page is already being temporarily watched, is it half-shaded in StructuredDiscussions? We probably don't need to implement support, due to its gradual deprecation, but this would be good to know for documentation purposes. I'll keep this ticket open until we confirm the current behavior.

FYI, I have also added a note about the lack of feature support in StructuredDiscussions in the Watchlist Expiry documentation (which is a current work in progress). Thanks!

One question for @dom_walden: If a page is already being temporarily watched, is it half-shaded in StructuredDiscussions?

Yes.

Perhaps this ticket could be repurposed to fix the bugs described in T249259#6148287?

Perhaps this ticket could be repurposed to fix the bugs described in T249259#6148287?

@ifried Sorry to ping you again, but I just thought I would bring this up again.

Even though we are not going to support StructuredDiscussion in watchlist expiry, currently it is interfering with the UX in ways that might confuse users.

I will probably raise a separate bug. EDIT: Raised as T263135.