| • Whatamidoing-WMF | |
| May 20 2020, 6:50 PM |
| F31846737: image.png | |
| May 29 2020, 11:54 AM |
| F31845868: Screen Shot 2020-05-28 at 3.37.32 PM.png | |
| May 28 2020, 10:43 PM |
| F31834352: Screen Shot 2020-05-20 at 11.49.27 AM.png | |
| May 20 2020, 6:50 PM |
Steps to Reproduce:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| ReplyWidget: Use interface dir for UI | mediawiki/extensions/DiscussionTools | master | +9 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T233443 [Epic] Reply Tool | |||
| Resolved | • ppelberg | T235924 Replies v2.0: release replying to specific comments | |||
| Resolved | • ppelberg | T235593 Replies v2.0: create mockups | |||
| Resolved | • iamjessklein | T246245 Reply v2.0: Create annotated tickets for posting on-wiki | |||
| Resolved | • Whatamidoing-WMF | T248629 Reply v2.0 designs: publicize request for community feedback | |||
| Resolved | • ppelberg | T245221 Replies v2.0: Engineering | |||
| Resolved | • ppelberg | T251654 Deploy Replying v2.0 as Beta Feature to partner wikis | |||
| Resolved | Esanders | T250523 Determine which Reply text input should be shown by default | |||
| Resolved | • iamjessklein | T246190 Reply v2.0: conduct usability tests (usertesting.com) | |||
| Resolved | Esanders | T234403 Create a VE-based text input for replying | |||
| Resolved | BUG REPORT | • ppelberg | T253255 Discussion tool uses content language direction for UI |
We should set dir="ltr" / dir="rtl" on the widget depending on the user language direction – it's inserted in the middle of the page content, so it currently uses content language direction. That seems to fix the visual issues.
I am not sure if we should also set it on the actual editing area depending on the content language direction again? I guess technically whatever you write there will be then inserted into the page and use content directionality, but in practice if you're using 'uselang=en' then you're probably typing in English, and will be annoyed by parentheses etc. being in the wrong direction.
We should always use content language/dir for the editor surface (we do), and the interface language for the toolbar and other controls (we don't yet).
In the case you are actually writing a message in the "wrong" language and want to change the content direction while composing there is a tool for that in VE (ctrl+shift+x).
Change 597636 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Use interface dir for UI
Change 597636 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Use interface dir for UI
nl wiki is still showing the menu options in English, other than that, the direction and the language look okay for other target wikis.
Sorry, I should've titled this "content language direction". If you have uselang=en, the interface should be in English, but that shouldn't break the layout of the reply widget on RTL wikis.
Here is the new behaviour on Arabic wiki with interface language set to English:
Green areas are content and therefore RTL, blue areas are interface and therefore LTR.
Here is the new behaviour on Arabic wiki with interface language set to English:
Green areas are content and therefore RTL, blue areas are interface and therefore LTR.
Understood, thanks @Esanders!