Page MenuHomePhabricator

Upgrade turnilo to latest upstream
Closed, ResolvedPublic

Description

We are lagging a bit from the last Turnilo upstream version (we have 1.17, last is 1.24) so we should upgrade.

Changelog: https://github.com/allegro/turnilo/releases

Event Timeline

elukey triaged this task as Medium priority.May 21 2020, 9:04 AM
elukey created this task.

Change 602367 had a related patch set uploaded (by Elukey; owner: Elukey):
[analytics/turnilo/deploy@master] Upgrade to upstream version 1.24.0

https://gerrit.wikimedia.org/r/602367

Change 602371 had a related patch set uploaded (by Elukey; owner: Elukey):
[operations/puppet@production] Add Turnilo to the staging environment on an-tool1007

https://gerrit.wikimedia.org/r/602371

Change 602440 had a related patch set uploaded (by Elukey; owner: Elukey):
[operations/puppet@production] turnilo: move functionalities to the proxy profile

https://gerrit.wikimedia.org/r/602440

Change 602440 merged by Elukey:
[operations/puppet@production] turnilo: move functionalities to the proxy profile

https://gerrit.wikimedia.org/r/602440

Change 602371 merged by Elukey:
[operations/puppet@production] Add Turnilo to the staging environment on an-tool1007

https://gerrit.wikimedia.org/r/602371

Change 602367 abandoned by Elukey:
Upgrade to upstream version 1.24.0

Reason:
will file a new one

https://gerrit.wikimedia.org/r/602367

Change 602604 had a related patch set uploaded (by Elukey; owner: Elukey):
[analytics/turnilo/deploy@master] Upgrade to upstream version 1.24.0

https://gerrit.wikimedia.org/r/602604

Added Turnilo to an-tool1005 (the superset staging instance) and deployed 1.24 to it. Sent an email to the team to test, after the green light I'll deploy to prod.

elukey added a project: Analytics-Kanban.
elukey set Final Story Points to 5.
elukey moved this task from Next Up to In Code Review on the Analytics-Kanban board.

Change 602604 merged by Elukey:
[analytics/turnilo/deploy@master] Upgrade to upstream version 1.24.0

https://gerrit.wikimedia.org/r/602604

Just deployed the new version!

@elukey I seem to have lost the ability to un-pin items from showing up in the graph. It's hard to describe, but using the colored squared seen in this screenshot, I could filter items in/out of the chart without using the formal filter function. This was incredibly handy when looking at large breakdowns like the one shown. I'm hoping it's a config setting that you can change.

Screen Shot 2020-06-05 at 2.00.54 PM.png (1×2 px, 1 MB)

(link to actual chart)

@JKatzWMF I got a similar report from SRE as well, I believe it is due to this:

https://github.com/allegro/turnilo/releases/tag/1.24.0

Simplified Line Chart legend
This time we removed something from turnilo. Legend is now simplified - it is read only and all values are derived from your split and filter definitions. No more out of sync bugs. (#595) (5d0fbd6)

So it seems a choice that upstream made :(

@elukey Ahh, bummer! Thanks for looking into it.