Page MenuHomePhabricator

Use frameless tabs
Closed, ResolvedPublic

Description

The original design spec in T215642 called for frameless tabs:

image.png (223×405 px, 14 KB)

However in production we are currently using framed tabs:

image.png (166×377 px, 7 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 597803 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/WikibaseMediaInfo@master] Use frameless tabs per the original specification

https://gerrit.wikimedia.org/r/597803

There was some discussion on if moving to frameless was what we wanted here so I did a bit more digging to get myself an opinion!

In general I was a bit confused why would we have two different tab styles that accomplish the same interaction pattern. The design system should usually make this decision quickly and clearly for us. Chatting with Volker, it seems like the framed tabs were the original approach in Special:Preferences and still has some application uses.

That being said, @Volker_E made some good points about how in an already interface heavy view like this one that the frameless option is a better choice and closer to what we are aiming for in the future of our UI.

Change 597803 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Use frameless tabs per the original specification

https://gerrit.wikimedia.org/r/597803

In general I was a bit confused why would we have two different tab styles that accomplish the same interaction pattern. The design system should usually make this decision quickly and clearly for us.

I made this same point when frameless was introduced, I agree it's a little confusing.

In general I was a bit confused why would we have two different tab styles that accomplish the same interaction pattern. The design system should usually make this decision quickly and clearly for us.

I made this same point when frameless was introduced, I agree it's a little confusing.

See T215644#5256984 and surrounding comments.

Ramsey-WMF claimed this task.

The new frameless tabs are up on production Commons now.