Deprecate the `.menu` class
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	May 21 2020, 5:32 PM

Description

Per T249372#6147215

the deprecated class="menu" reserved for Legacy Vectors dropdown menus to become applied to all sidebar portlets, p-personal and tab areas in Legacy Vector and New Vector. Could this class be limited to a condition only enabled for Legacy Vector's dropdown menus?

Acceptance criteria

Only use the deprecated menu class on dropdown menus

sign off steps

Identify a plan for removing the .menu class altogether from the Vector codebase.

Details

	Subject	Repo	Branch	Lines +/-
	Reduce distribution of legacy classes	mediawiki/skins/Vector	master	+33 -5

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdrewniak	T249372 [Dev] DRY up the menu templating code
		Resolved		Jdlrobson	T253329 Deprecate the `.menu` class

Event Timeline

Jdlrobson created this task.May 21 2020, 5:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 21 2020, 5:32 PM

Jdlrobson mentioned this in T249372: [Dev] DRY up the menu templating code.May 21 2020, 5:32 PM

Jdlrobson updated the task description. (Show Details)May 21 2020, 6:43 PM

Change 597849 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@master] Reduce distribution of legacy classes

https://gerrit.wikimedia.org/r/597849

gerritbot added a project: Patch-For-Review.May 21 2020, 6:51 PM