Page MenuHomePhabricator

Special:CargoTables doesn't show a link to Special:MultiPageEdit if the form has spaces in its name
Open, Needs TriagePublicBUG REPORT

Description

Steps to Reproduce:
Create a template and a form named "Hello World". Go to Special:CargoTables.

Actual Results:
No edit link shows.

Expected Results:
Edit link.

It seems PFHooks::getFormForTemplate() is passed a template name with spaces, but looks at an array where the name is encoded with underscores. The simplest solution is to add the line:

$templateName = str_replace( ' ', '_', $templateName );

As the first line in PFHooks::getFormForTemplate().
I'd send a patch for review, but my gerrit knowledge is extremely rusty right now. If I figure it out in the next hour, I'll send one.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, May 21, 9:44 PM

Apparently, I'm really bad at using git-review... Let's see if I can manually link the change: Change 597880

Change 597880 had a related patch set uploaded (by BryanDavis; owner: FreedomFighterSparrow):
[mediawiki/extensions/PageForms@master] Special:CargoTables: show multipageedit links for space-named forms

https://gerrit.wikimedia.org/r/597880

Change 597880 merged by jenkins-bot:
[mediawiki/extensions/PageForms@master] Special:CargoTables: show multipageedit links for templates w/ spaces in name

https://gerrit.wikimedia.org/r/597880

Apparently, I'm really bad at using git-review... Let's see if I can manually link the change: Change 597880

@FreedomFighterSparrow: Please see https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines - thanks!

@Aklapper, I read that and actually did change the commit message accordingly (https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PageForms/+/597880/1..2//COMMIT_MSG), but it still wasn't picked up...

@FreedomFighterSparrow: That's expected as there was an empty line between Bug: Txxxx and Change-Id:. So it wasn't accordingly. :)

@Aklapper, I see, and I'll keep that in mind. Thank you.