Page MenuHomePhabricator

Focus not visible on Button on high contrast mode
Open, LowestPublicBUG REPORT

Description

Steps to Reproduce:

  • Go to any page with a ooui button
  • Turn on high contrast mode
  • Navigate to the button using keyboard

Actual Results:

  • No focus is visible on the button

Expected Results:

  • There should be a visual indication that the current button is in focus

Event Timeline

My open questions in T253598#6193715 remain, the approach of preferring proprietary high contrast mode over any other mode and environment isn't sufficient for our scope and reach. If we can't address high contrast mode focus differently (and without a lot of extra code), taking away custom focus behavior will not be merged at current understanding.

Change 607640 had a related patch set uploaded (by Bkudiess-msft; owner: Bkudiess-msft):
[oojs/ui@master] Adds button focus in high contrast mode

https://gerrit.wikimedia.org/r/607640

Status quo:

image.png (138×324 px, 7 KB)

With patch:
image.png (132×320 px, 7 KB)

Notice the far bigger radius.

Change 607640 merged by jenkins-bot:
[oojs/ui@master] WikimediaUI theme: Add button focus for Windows high contrast mode

https://gerrit.wikimedia.org/r/607640

Change 611174 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.39.3

https://gerrit.wikimedia.org/r/611174

Change 611174 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.39.3

https://gerrit.wikimedia.org/r/611174