Page MenuHomePhabricator

Show/Hide description buttons are not accessible by keyboard
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  • Go to a page
  • Navigate till talk and hit enter
  • Navigate till "show description" button

Actual Results:
Issue 1: "Hide Description" button is not accessible by Keyboard.
Issue 2: "Show Description" button is not accessible by Keyboard.

Expected Results:
Hide and Show description buttons should be accessible by keyboard

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 598116 had a related patch set uploaded (by Catrope; owner: Bkudiess-msft):
[mediawiki/extensions/Flow@master] Adds keyboard focus outline to show/hide description button

https://gerrit.wikimedia.org/r/598116

Change 598119 had a related patch set uploaded (by Catrope; owner: Bkudiess-msft):
[mediawiki/extensions/Flow@master] Adds control type for show/hide description button

https://gerrit.wikimedia.org/r/598119

Change 598119 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Adds control type for show/hide description button

https://gerrit.wikimedia.org/r/598119

@Catrope Should the DOM position and with that the keyboard focus order also be reconsidered?

There was a 2nd patch in this task that is still pending
https://gerrit.wikimedia.org/r/598116

just want to follow up on the status. Thanks!

Change 598116 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/Flow@master] Adds keyboard focus outline to show/hide description button

Reason:

Seems already fixed, see task

https://gerrit.wikimedia.org/r/598116

The buttons have a visible focus state now. I think this has been fixed in MediaWiki core by rMW9acb3b2177f2: Align quiet buttons with style guide in 2021, and improved by other patches since.