Page MenuHomePhabricator

[OTRS bug] "Sojourner (rover)" article shows text-on-text
Closed, DuplicatePublic

Description

From OTRS: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=11390663

Tested on 6.6, still occurring.

Article "Sojourner (rover)": desktop web (ok), mobile web (overlap), parsoid (ok), mobile-html (overlap)

Observations:

The problem is only visible for device/browser widths <= 720px.
The problem is also visible direclty in the template:
https://en.wikipedia.org/api/rest_v1/page/mobile-html/Template:Mars_map

Removing this rules from hacks.less fixes the problem here:

// Deal with Template:Multiple_image.  T38030 and T148505
.thumb .thumbinner {
  .flex-display( flex );
  justify-content: center;
  flex-wrap: wrap;
  align-content: flex-start;
  // avoid image child overflowing the container (T200518)
  // stylelint-disable-next-line declaration-block-no-redundant-longhand-properties
  flex-direction: column;

  > .thumbcaption {
    .flex( 1, 0, 100% );
    display: block;
  }
}

Turning off display: flex avoids this overlap as well.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, May 22, 11:49 PM
MattCleinman renamed this task from "Sojourner (rover)" article shows terribly to "Sojourner (rover)" article shows text-on-text.Fri, May 22, 11:50 PM
MattCleinman updated the task description. (Show Details)
MattCleinman renamed this task from "Sojourner (rover)" article shows text-on-text to [OTRS bug] "Sojourner (rover)" article shows text-on-text.Tue, May 26, 4:36 PM
dcipoletti triaged this task as Low priority.Wed, Jun 3, 5:27 PM
bearND updated the task description. (Show Details)Wed, Jun 3, 5:50 PM
bearND updated the task description. (Show Details)Fri, Jun 5, 8:27 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptFri, Jun 5, 8:27 PM
bearND updated the task description. (Show Details)Fri, Jun 5, 9:39 PM
bearND updated the task description. (Show Details)
bearND updated the task description. (Show Details)Fri, Jun 5, 9:43 PM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptFri, Jun 5, 9:43 PM
bearND added subscribers: dcipoletti, bearND.

@dcipoletti I think this is an issue in MinervaNeue. If I added the wrong project please add the correct project.

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptFri, Jun 5, 9:52 PM

Per T207618 this is not a browser we support. Feel free to reopen that ticket and debate there is if necessary.

bearND reopened this task as Open.EditedFri, Jun 5, 10:23 PM

This also happens on Chrome and FF. All that is needed to reproduce is reduce your browser window width to < 721px and go to https://en.m.wikipedia.org/wiki/Sojourner_(rover)#Sojourner's_location_in_context.

@bearND it's the same bug as T207618 if this is about flexbox. Given T207618#5400133 we decided not to support browsers which don't support flex box. Please continue conversation on T207618.

If it's just about the overlap that's a template issue like most of these problems tend to be. I've fixed it on wiki for you: https://en.m.wikipedia.org/wiki/Special:MobileDiff/960968868?diffmode=source

@Jdlrobson Yes, this was about the overlap. Thanks for fixing this on-wiki.