Move information about user edits to a new service
Closed, ResolvedPublic
Actions

Description

User::getEditCount
User::getFirstEditTimestamp
User::getLatestEditTimestamp
User::getEditTimestamp
User::initEditCountInternal

should be moved to a new service, perhaps UserEditTracker:

Inject a LoadBalancer
Inject an ActorMigration

This avoids needing to retrieve the services via MediaWikiServices and is another step towards splitting the User "god object"

Details

	Subject	Repo	Branch	Lines +/-
	Add a new UserEditTracker service for user edit counts and timing	mediawiki/core	master	+654 -77

Customize query in gerrit

Related Objects

Mentioned In: T233385: Expand phpunit tests for User.php

Event Timeline

DannyS712 created this task.May 23 2020, 12:32 AM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptMay 23 2020, 12:32 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DannyS712 updated the task description. (Show Details)May 23 2020, 12:37 AM

DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

DannyS712 updated the task description. (Show Details)May 26 2020, 1:40 AM

Change 598566 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add a new UserEditTracker service for user edit counts and timing

https://gerrit.wikimedia.org/r/598566

gerritbot added a project: Patch-For-Review.May 26 2020, 3:33 AM

DannyS712 claimed this task.May 26 2020, 3:38 AM

DannyS712 added a project: Platform Team Workboards (External Code Reviews).

DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.

• eprodromou removed a project: Platform Engineering.May 26 2020, 8:16 PM

Change 598566 merged by jenkins-bot:
[mediawiki/core@master] Add a new UserEditTracker service for user edit counts and timing

https://gerrit.wikimedia.org/r/598566

Change 601559 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Make use of new UserEditTracker service, deprecate User methods

https://gerrit.wikimedia.org/r/601559

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.35; 2020-06-02).Jun 2 2020, 4:00 AM

• Onkoydenkovuldum edited projects, added Articles Needing links; removed MediaWiki-User-management.Jun 4 2020, 11:36 PM

Reedy edited projects, added MediaWiki-User-management; removed Articles Needing links.Jun 4 2020, 11:53 PM

Actual service was merged and is live

DannyS712 mentioned this in T233385: Expand phpunit tests for User.php.Jun 6 2020, 4:51 AM

Move information about user edits to a new serviceClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Move information about user edits to a new service
Closed, ResolvedPublic
Actions